Merge pull request cli#1187 from gabgodBB/Disabling_color_for_output_…

…file

Issue cli#930 - Removing color for output files

utils/color.go

@@ -10,8 +10,7 @@ import (
 )
 
 var (
-	_isColorEnabled                                    bool = true
-	_isStdoutTerminal, checkedTerminal, checkedNoColor bool
+	_isStdoutTerminal, checkedTerminal bool
 
 	// Outputs ANSI color if stdout is a tty
 	Magenta = makeColorFunc("magenta")
@@ -45,17 +44,17 @@ func NewColorable(f *os.File) io.Writer {
 func makeColorFunc(color string) func(string) string {
 	cf := ansi.ColorFunc(color)
 	return func(arg string) string {
-		if isColorEnabled() && isStdoutTerminal() {
+		if isColorEnabled() {
 			return cf(arg)
 		}
 		return arg
 	}
 }
 
 func isColorEnabled() bool {
-	if !checkedNoColor {
-		_isColorEnabled = os.Getenv("NO_COLOR") == ""
-		checkedNoColor = true
+	if os.Getenv("NO_COLOR") != "" {
+		return false
 	}
-	return _isColorEnabled
+
+	return isStdoutTerminal()
 }