This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
Send welcome email after verification email #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto development
[0.1 & 1.1] Created style folder and added /challengerwelcome page
conflict resolution
Task 1.5: Build the /progress page
* Add react-meta-tags package * Change signup form to html with floating labels from react-bootstrap * Change error check to strict equal * Update underline class text * Bug fix on sign up if field left blank got firebase error
* Fix the Underline bug * Remove .idea folder from git * Refactor into folders * A small bug in the styling * Refactored more items into folders so that it's easier to tell what each component is used/used for. * Fix some bugs with the image paths not changing * try to fix stuff * Update Actions.js * Fix some git errors
* jumping jump to progress page * simplified syntax Co-authored-by: Devanshu Sen Pandey <[email protected]>
* Fixed a lot of the console errors and warnings. * Saw that there was copies of some components and they weren't used anywhere so removed them. Also, fixed some files code styling. * Extra copy of chellengerwelcome.js Co-authored-by: Devanshu Sen Pandey <[email protected]>
* Built a page, added links and new info Built the Why 8BY8 page, added required links on 3 pages and the sidebar menu. Made the required edits to the player welcome and challenger welcome pages * spacing and padding changes in /why8by8 * Repositioned links and fixed blob rendering issue * spacing updates * styling /why8by8 page * delete /why8by8.scss file * style file name change Co-authored-by: Devanshu <[email protected]>
* integrate RTV Election Reminder form * Added voter registration route * styled election reminders form, made updates to voterregistrationform * election reminder form now updates user document and checks if the user has already signed up for reminders, also redirects to actions * voter registration form visual flow complete * integrated voter reg frontend with api, fixed bug in frontend * made some small improvements to the UI * voter registration flow now includes tooltips and registration status check * voter registration flow ready for end-to-end testing * updated styling in election reminders and voter registration, loading wheel can now be set to a block-style display * eligibility page now re-evaluates elibility if dob is updated after the zip has been entered and elibility has already been determined * resolved conflict in package-lock.json * updated election reminders loading screen and loading wheel component * fixed a few bugs in the voter registration flow * fixed merge conflict in package.json * uncommented code that checks if the user has already registered to vote * separate voter registration flow into individual pages, store voterreg object in authcontext, styling fixes to voterreg flow, redirect user to appropriate page depending on their registration status and the information in the context * fixed election reminders bug * add call to address validation endpoint to address block component, rename optional fields in voter registration data to correspond to newly added api fields
* Added CRUD functions for partner database. * Fixed a small bug with the dates not showing up on the database if given empty strings.
…choosereward page (#172) * Start work on Rewards page * Conditionally render partners * Add placeholder images, final styling * Fix Authentication Bugs * Add the ChooseReward page skeleton * Update ChooseReward so that data is retrieved from the database * Finalize changes * Implement changes from PR feedback * Fix Underline issue (from design meeting) * Fix Font-weight issue (from design meeting) * Fixed an issue where the site would try to render too many times while grabbing partner data.
* change margin of Election Alerts page * add margin to the bigger container * Change link styles to bold and underline in black * update margin for reminders-completed * save voter reg info to firebase * fix import file path * update default value of VoterRegistrationData
* Add new voterreg comp elements * Add more info container * Add reminder and expect modals * Implement light/dark mode for PopupModal * Update reminder modal style * Add Reg by mail modal and style what to expect modal * Update styling for What to expect modal * Update styling and add links * get saved data from database Co-authored-by: Devanshu <[email protected]>
* integrate RTV Election Reminder form * Added voter registration route * styled election reminders form, made updates to voterregistrationform * election reminder form now updates user document and checks if the user has already signed up for reminders, also redirects to actions * voter registration form visual flow complete * integrated voter reg frontend with api, fixed bug in frontend * made some small improvements to the UI * voter registration flow now includes tooltips and registration status check * voter registration flow ready for end-to-end testing * updated styling in election reminders and voter registration, loading wheel can now be set to a block-style display * eligibility page now re-evaluates elibility if dob is updated after the zip has been entered and elibility has already been determined * resolved conflict in package-lock.json * updated election reminders loading screen and loading wheel component * fixed a few bugs in the voter registration flow * fixed merge conflict in package.json * uncommented code that checks if the user has already registered to vote * separate voter registration flow into individual pages, store voterreg object in authcontext, styling fixes to voterreg flow, redirect user to appropriate page depending on their registration status and the information in the context * fixed election reminders bug * add call to address validation endpoint to address block component, rename optional fields in voter registration data to correspond to newly added api fields * updated actions page to add links upon registering to vote, added general use-case error modal, updated design of address error messsages, cleaned up a few things
* Worked on issue 8.1 Added the required functionality to the /choosereward, /progress, and /actions pages. * bug style fixes Co-authored-by: Devanshu Pandey <[email protected]>
* redid signup page * email verification after signup + signup form cleanup * private route verification success page * signin verification email * signin verificaiton email logic * /verify page routing * firebase functions
…ist, fix visual bugs (#184) * integrate RTV Election Reminder form * Added voter registration route * styled election reminders form, made updates to voterregistrationform * election reminder form now updates user document and checks if the user has already signed up for reminders, also redirects to actions * voter registration form visual flow complete * integrated voter reg frontend with api, fixed bug in frontend * made some small improvements to the UI * voter registration flow now includes tooltips and registration status check * voter registration flow ready for end-to-end testing * updated styling in election reminders and voter registration, loading wheel can now be set to a block-style display * eligibility page now re-evaluates elibility if dob is updated after the zip has been entered and elibility has already been determined * resolved conflict in package-lock.json * updated election reminders loading screen and loading wheel component * fixed a few bugs in the voter registration flow * fixed merge conflict in package.json * uncommented code that checks if the user has already registered to vote * separate voter registration flow into individual pages, store voterreg object in authcontext, styling fixes to voterreg flow, redirect user to appropriate page depending on their registration status and the information in the context * fixed election reminders bug * add call to address validation endpoint to address block component, rename optional fields in voter registration data to correspond to newly added api fields * updated actions page to add links upon registering to vote, added general use-case error modal, updated design of address error messsages, cleaned up a few things * added partners context, fixed many visual bugs
* integrate RTV Election Reminder form * Added voter registration route * styled election reminders form, made updates to voterregistrationform * election reminder form now updates user document and checks if the user has already signed up for reminders, also redirects to actions * voter registration form visual flow complete * integrated voter reg frontend with api, fixed bug in frontend * made some small improvements to the UI * voter registration flow now includes tooltips and registration status check * voter registration flow ready for end-to-end testing * updated styling in election reminders and voter registration, loading wheel can now be set to a block-style display * eligibility page now re-evaluates elibility if dob is updated after the zip has been entered and elibility has already been determined * resolved conflict in package-lock.json * updated election reminders loading screen and loading wheel component * fixed a few bugs in the voter registration flow * fixed merge conflict in package.json * uncommented code that checks if the user has already registered to vote * separate voter registration flow into individual pages, store voterreg object in authcontext, styling fixes to voterreg flow, redirect user to appropriate page depending on their registration status and the information in the context * fixed election reminders bug * add call to address validation endpoint to address block component, rename optional fields in voter registration data to correspond to newly added api fields * updated actions page to add links upon registering to vote, added general use-case error modal, updated design of address error messsages, cleaned up a few things * added partners context, fixed many visual bugs * updated rewards page
* integrate RTV Election Reminder form * Added voter registration route * styled election reminders form, made updates to voterregistrationform * election reminder form now updates user document and checks if the user has already signed up for reminders, also redirects to actions * voter registration form visual flow complete * integrated voter reg frontend with api, fixed bug in frontend * made some small improvements to the UI * voter registration flow now includes tooltips and registration status check * voter registration flow ready for end-to-end testing * updated styling in election reminders and voter registration, loading wheel can now be set to a block-style display * eligibility page now re-evaluates elibility if dob is updated after the zip has been entered and elibility has already been determined * resolved conflict in package-lock.json * updated election reminders loading screen and loading wheel component * fixed a few bugs in the voter registration flow * fixed merge conflict in package.json * uncommented code that checks if the user has already registered to vote * separate voter registration flow into individual pages, store voterreg object in authcontext, styling fixes to voterreg flow, redirect user to appropriate page depending on their registration status and the information in the context * fixed election reminders bug * add call to address validation endpoint to address block component, rename optional fields in voter registration data to correspond to newly added api fields * updated actions page to add links upon registering to vote, added general use-case error modal, updated design of address error messsages, cleaned up a few things * added partners context, fixed many visual bugs * updated rewards page * user voter registration data is now saved to and looked up from a separate collection in the database.
* IG and SMS Invite/Share workflow, Issue #70 Created IG, SMS flow for Invite/Share, Issue #70 * Made link on one line, overflow hidden, Issue #70 * Fixed header text turning black * Update challenger won email * isChallenger for challengeWon email * Move challengerWelcome email to after email verify
* Worked on issue 8.1 Added the required functionality to the /choosereward, /progress, and /actions pages. * bug style fixes * Styling changes and correctly displaying data on the coupons Co-authored-by: Devanshu Pandey <[email protected]>
Deploying with
|
| Latest commit: |
ecdb5a6
|
| Status: | 🚫 Build failed. |
… to /actions page (#190) * integrate RTV Election Reminder form * Added voter registration route * styled election reminders form, made updates to voterregistrationform * election reminder form now updates user document and checks if the user has already signed up for reminders, also redirects to actions * voter registration form visual flow complete * integrated voter reg frontend with api, fixed bug in frontend * made some small improvements to the UI * voter registration flow now includes tooltips and registration status check * voter registration flow ready for end-to-end testing * updated styling in election reminders and voter registration, loading wheel can now be set to a block-style display * eligibility page now re-evaluates elibility if dob is updated after the zip has been entered and elibility has already been determined * resolved conflict in package-lock.json * updated election reminders loading screen and loading wheel component * fixed a few bugs in the voter registration flow * fixed merge conflict in package.json * uncommented code that checks if the user has already registered to vote * separate voter registration flow into individual pages, store voterreg object in authcontext, styling fixes to voterreg flow, redirect user to appropriate page depending on their registration status and the information in the context * fixed election reminders bug * add call to address validation endpoint to address block component, rename optional fields in voter registration data to correspond to newly added api fields * updated actions page to add links upon registering to vote, added general use-case error modal, updated design of address error messsages, cleaned up a few things * added partners context, fixed many visual bugs * updated rewards page * user voter registration data is now saved to and looked up from a separate collection in the database. * Promisify firebase https functions to aid in debugging * update go to challenge link after completing voter reg to link to actions page
Devanshusp
suggested changes
Sep 24, 2022
There was a problem hiding this comment.
The emailing works as specified, just a few merge conflicts, will merge once fixed
Thanks @dvorakjt!!
Removing unused imports/variables, added/fixing img tag alt text, addressing code style issues like use of != over !==, use of class over className, changed links to buttons and fixed useEffect arrays.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR moves the send welcome email feature into the verification success component, correcting the issue of the welcome email arriving prior to or at the same time as the verification email.
Test Plan
This PR was tested manually in the browser by going through the sign up and verify flow.
Follow ups
This branch has conflicts which must be resolved. We will just need to verify it is working as expected in production.