Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Challenger welcome to Next.js #235

Merged

Conversation

MazharulIslam-Naim
Copy link
Member

Overview

This PR migrates the challenger welcome page and the rewards context to next.js.

Test Plan

I wrote snapshot tests for the page and unit tests for the buttons and rewards context.

Copy link
Contributor

@dvorakjt dvorakjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Naim,

Looks great! The code is really clear and easy to follow and the tests look good. We'll just need to create a PR for this in the new repo, with some minor adaptations to reflect the new environment. Good work.

@dvorakjt dvorakjt merged commit ec206be into 8by8-org:next-js-migration Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants