Skip to content

fix: metadata badge interactions in trace list #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turisanapo merged 2 commits into from
Mar 19, 2026
+19 −10
Merged

fix: metadata badge interactions in trace list #295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f17de7
fix: filter side effects
heiwen Mar 19, 2026
5d7e225
fix: move preventDefault to higher level
heiwen Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions apps/console/app/routes/_shell.agent.$agentSlug.branch.$branchSlug.traces/list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,11 @@ export function TraceList({
</p>

{Object.keys(trace.metadata).length > 0 && (
<TagStrip metadata={trace.metadata} activeMetadata={metadata} allKeys={metadataKeys} />
<TagStrip
metadata={trace.metadata}
activeMetadata={metadata}
allKeys={metadataKeys}
/>
)}
</Link>
);
Expand Down Expand Up @@ -230,18 +234,21 @@ function TagStrip({
activeMetadata: Record<string, string>;
allKeys: string[];
}) {
const [open, setOpen] = useState(false);

const { updateParams } = useTraceSearchParams();

const entries = Object.entries(metadata).sort(([a], [b]) => a.localeCompare(b));
const visible = entries.slice(0, VISIBLE_TAG_COUNT);
const overflowCount = entries.length - visible.length;

function toggleMetadataFilter(key: string, value: string, event: React.MouseEvent) {
event.stopPropagation();
event.preventDefault();
updateParams((sp) => sp.toggleValue("metadata", key, value));
setOpen(false);
}

return (
<HoverCard>
<HoverCard open={open} onOpenChange={setOpen}>
<HoverCardTrigger
delay={250}
closeDelay={100}
Expand All @@ -266,7 +273,13 @@ function TagStrip({
}
/>
{entries.length >= VISIBLE_TAG_COUNT && (
<HoverCardContent align="start" className="w-auto">
<HoverCardContent
align="start"
className="w-auto"
onClick={(e) => {
e.preventDefault();
}}
>
<div className="flex flex-col gap-1.5">
{entries.map(([key, value]) => (
<TagBadge
Expand Down Expand Up @@ -323,11 +336,7 @@ function TagBadge({
style?: React.CSSProperties;
}) {
return (
<Badge
variant="secondary"
className="group/tag shrink-0 gap-1 pr-1"
style={style}
>
<Badge variant="secondary" className="group/tag shrink-0 gap-1 pr-1" style={style}>
{badgeKey}: {value}
<button
type="button"
Expand Down