chore: 사용되지 않는 presigned URL 발급 기능 제거 - #25
Merged
Conversation
미션 인증이 파일 직접 업로드(POST /today/certification, S3StorageService)로 확정되어 presigned URL 방식은 아무도 호출하지 않는다. 죽은 코드를 제거한다. - ImageController, PresignedUrlService, Presigned* DTO, 테스트 삭제 - S3Config: s3Presigner 빈 제거 (s3Client 는 업로드에 쓰이므로 유지) - ErrorCode: IMAGE_ERROR_500_PRESIGNED_URL_FAILED 제거 S3StorageService / S3Config#s3Client / S3Properties 는 그대로 유지된다. clean build 통과. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📝 WalkthroughWalkthrough이미지 presigned URL 발급 API와 관련 DTO·서비스가 삭제되고, S3 presigner 설정이 제거되었습니다. 이미지 오류 코드는 업로드 실패 코드로 변경되었으며, Changes이미지 업로드 변경
문서 디렉터리 추적 제외
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/main/java/com/example/hackathon/domain/image/config/S3Config.java (1)
41-49: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
presignedUrlExpirationSeconds설정 삭제
S3Properties.S3에서 더 이상 쓰이지 않으니S3Properties.java와application.yml의presigned-url-expiration-seconds항목을 함께 제거해 주세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/com/example/hackathon/domain/image/config/S3Config.java` around lines 41 - 49, Remove the unused presignedUrlExpirationSeconds configuration from the S3Properties.S3 record/class and delete the corresponding presigned-url-expiration-seconds entry from application.yml, ensuring no remaining references or binding logic depend on it.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/main/java/com/example/hackathon/domain/image/config/S3Config.java`:
- Around line 41-49: Remove the unused presignedUrlExpirationSeconds
configuration from the S3Properties.S3 record/class and delete the corresponding
presigned-url-expiration-seconds entry from application.yml, ensuring no
remaining references or binding logic depend on it.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 611d27a1-99a8-4dbc-93d7-23286239f551
📒 Files selected for processing (8)
.gitignoresrc/main/java/com/example/hackathon/domain/image/config/S3Config.javasrc/main/java/com/example/hackathon/domain/image/controller/ImageController.javasrc/main/java/com/example/hackathon/domain/image/dto/PresignedUrlRequest.javasrc/main/java/com/example/hackathon/domain/image/dto/PresignedUrlResponse.javasrc/main/java/com/example/hackathon/domain/image/service/PresignedUrlService.javasrc/main/java/com/example/hackathon/global/exception/ErrorCode.javasrc/test/java/com/example/hackathon/domain/image/service/PresignedUrlServiceTest.java
💤 Files with no reviewable changes (6)
- src/main/java/com/example/hackathon/domain/image/dto/PresignedUrlResponse.java
- src/main/java/com/example/hackathon/domain/image/service/PresignedUrlService.java
- src/test/java/com/example/hackathon/domain/image/service/PresignedUrlServiceTest.java
- src/main/java/com/example/hackathon/domain/image/dto/PresignedUrlRequest.java
- src/main/java/com/example/hackathon/global/exception/ErrorCode.java
- src/main/java/com/example/hackathon/domain/image/controller/ImageController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
미션 인증이 파일 직접 업로드(POST /today/certification, S3StorageService)로 확정되어 presigned URL 방식은 아무도 호출하지 않는다. 죽은 코드를 제거한다.
S3StorageService / S3Config#s3Client / S3Properties 는 그대로 유지된다. clean build 통과.
Summary by CodeRabbit
변경 사항
정리
docs/폴더의 파일은 버전 관리 대상에서 제외됩니다.