Skip to content

chore: 사용되지 않는 presigned URL 발급 기능 제거 - #25

Merged
hyeonszz merged 1 commit into
mainfrom
chore/remove-presigned-url
Jul 10, 2026
Merged

chore: 사용되지 않는 presigned URL 발급 기능 제거#25
hyeonszz merged 1 commit into
mainfrom
chore/remove-presigned-url

Conversation

@hyeonszz

@hyeonszz hyeonszz commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

미션 인증이 파일 직접 업로드(POST /today/certification, S3StorageService)로 확정되어 presigned URL 방식은 아무도 호출하지 않는다. 죽은 코드를 제거한다.

  • ImageController, PresignedUrlService, Presigned* DTO, 테스트 삭제
  • S3Config: s3Presigner 빈 제거 (s3Client 는 업로드에 쓰이므로 유지)
  • ErrorCode: IMAGE_ERROR_500_PRESIGNED_URL_FAILED 제거

S3StorageService / S3Config#s3Client / S3Properties 는 그대로 유지된다. clean build 통과.

Summary by CodeRabbit

  • 변경 사항

    • 이미지 업로드용 사전 서명 URL 발급 기능과 관련 API가 제거되었습니다.
    • 기존 이미지 업로드 요청 및 응답 형식이 더 이상 제공되지 않습니다.
    • 이미지 업로드 실패 시 표시되는 오류 유형이 보다 명확한 메시지로 변경되었습니다.
  • 정리

    • 이미지 업로드 관련 기존 기능과 검증 항목이 정리되었습니다.
    • docs/ 폴더의 파일은 버전 관리 대상에서 제외됩니다.

미션 인증이 파일 직접 업로드(POST /today/certification, S3StorageService)로
확정되어 presigned URL 방식은 아무도 호출하지 않는다. 죽은 코드를 제거한다.

- ImageController, PresignedUrlService, Presigned* DTO, 테스트 삭제
- S3Config: s3Presigner 빈 제거 (s3Client 는 업로드에 쓰이므로 유지)
- ErrorCode: IMAGE_ERROR_500_PRESIGNED_URL_FAILED 제거

S3StorageService / S3Config#s3Client / S3Properties 는 그대로 유지된다.
clean build 통과.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@hyeonszz hyeonszz self-assigned this Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

이미지 presigned URL 발급 API와 관련 DTO·서비스가 삭제되고, S3 presigner 설정이 제거되었습니다. 이미지 오류 코드는 업로드 실패 코드로 변경되었으며, docs/ 디렉터리는 Git 추적에서 제외됩니다.

Changes

이미지 업로드 변경

Layer / File(s) Summary
Presigned URL 경로 및 오류 코드 정리
src/main/java/com/example/hackathon/domain/image/controller/ImageController.java, src/main/java/com/example/hackathon/domain/image/dto/*, src/main/java/com/example/hackathon/domain/image/service/PresignedUrlService.java, src/main/java/com/example/hackathon/domain/image/config/S3Config.java, src/main/java/com/example/hackathon/global/exception/ErrorCode.java, src/test/java/com/example/hackathon/domain/image/service/PresignedUrlServiceTest.java
이미지 presigned URL 엔드포인트, 요청·응답 DTO, 발급 서비스와 테스트가 삭제되었습니다. S3Presigner 빈이 제거되고 이미지 오류 코드가 업로드 실패 코드로 변경되었습니다.

문서 디렉터리 추적 제외

Layer / File(s) Summary
문서 디렉터리 무시 설정
.gitignore
docs/ 디렉터리를 Git 무시 대상으로 추가했습니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 사용되지 않는 presigned URL 발급 기능을 제거한다는 점을 정확하고 간결하게 요약합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-presigned-url

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/main/java/com/example/hackathon/domain/image/config/S3Config.java (1)

41-49: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

presignedUrlExpirationSeconds 설정 삭제
S3Properties.S3에서 더 이상 쓰이지 않으니 S3Properties.javaapplication.ymlpresigned-url-expiration-seconds 항목을 함께 제거해 주세요.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/java/com/example/hackathon/domain/image/config/S3Config.java` around
lines 41 - 49, Remove the unused presignedUrlExpirationSeconds configuration
from the S3Properties.S3 record/class and delete the corresponding
presigned-url-expiration-seconds entry from application.yml, ensuring no
remaining references or binding logic depend on it.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/main/java/com/example/hackathon/domain/image/config/S3Config.java`:
- Around line 41-49: Remove the unused presignedUrlExpirationSeconds
configuration from the S3Properties.S3 record/class and delete the corresponding
presigned-url-expiration-seconds entry from application.yml, ensuring no
remaining references or binding logic depend on it.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 611d27a1-99a8-4dbc-93d7-23286239f551

📥 Commits

Reviewing files that changed from the base of the PR and between bd35dde and 8d0087d.

📒 Files selected for processing (8)
  • .gitignore
  • src/main/java/com/example/hackathon/domain/image/config/S3Config.java
  • src/main/java/com/example/hackathon/domain/image/controller/ImageController.java
  • src/main/java/com/example/hackathon/domain/image/dto/PresignedUrlRequest.java
  • src/main/java/com/example/hackathon/domain/image/dto/PresignedUrlResponse.java
  • src/main/java/com/example/hackathon/domain/image/service/PresignedUrlService.java
  • src/main/java/com/example/hackathon/global/exception/ErrorCode.java
  • src/test/java/com/example/hackathon/domain/image/service/PresignedUrlServiceTest.java
💤 Files with no reviewable changes (6)
  • src/main/java/com/example/hackathon/domain/image/dto/PresignedUrlResponse.java
  • src/main/java/com/example/hackathon/domain/image/service/PresignedUrlService.java
  • src/test/java/com/example/hackathon/domain/image/service/PresignedUrlServiceTest.java
  • src/main/java/com/example/hackathon/domain/image/dto/PresignedUrlRequest.java
  • src/main/java/com/example/hackathon/global/exception/ErrorCode.java
  • src/main/java/com/example/hackathon/domain/image/controller/ImageController.java

@hyeonszz
hyeonszz merged commit df35c71 into main Jul 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant