Skip to content

[feat] 기본 집안일 목록 조회 구현 - #12

Merged
leehwx merged 1 commit into
developfrom
feat/signup
Jul 10, 2026
Merged

[feat] 기본 집안일 목록 조회 구현#12
leehwx merged 1 commit into
developfrom
feat/signup

Conversation

@leehwx

@leehwx leehwx commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added an API for retrieving the full list of chores, including category, name, difficulty, score, and notes.
    • Authentication responses now include the groups associated with the signed-in member.
  • Validation
    • Signup passwords must be at least 8 characters and contain both letters and numbers.
    • Updated password guidance and validation messages.
  • Documentation
    • Added the chore listing endpoint to the API documentation.

@leehwx
leehwx merged commit 7acad07 into develop Jul 10, 2026
1 check passed
@leehwx leehwx self-assigned this Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 89acfa54-7064-426f-8858-06426bc0f14c

📥 Commits

Reviewing files that changed from the base of the PR and between 4675008 and ee1ef8e.

📒 Files selected for processing (8)
  • src/main/java/com/cotato/cokerthon/domain/auth/dto/request/SignupRequest.java
  • src/main/java/com/cotato/cokerthon/domain/auth/dto/response/AuthResponse.java
  • src/main/java/com/cotato/cokerthon/domain/auth/service/AuthService.java
  • src/main/java/com/cotato/cokerthon/domain/chore/controller/ChoreController.java
  • src/main/java/com/cotato/cokerthon/domain/chore/dto/response/ChoreResponse.java
  • src/main/java/com/cotato/cokerthon/domain/chore/service/ChoreService.java
  • src/main/java/com/cotato/cokerthon/domain/group/repository/GroupMemberRepository.java
  • src/main/java/com/cotato/cokerthon/global/config/SwaggerConfig.java

📝 Walkthrough

Walkthrough

Authentication now validates password complexity and includes member group IDs in responses. A read-only chore listing API was added, with entity-to-DTO mapping, controller wiring, and Swagger path registration.

Changes

Authentication updates

Layer / File(s) Summary
Signup password validation
src/main/java/com/cotato/cokerthon/domain/auth/dto/request/SignupRequest.java
Signup passwords now require at least eight characters, including at least one letter and one digit.
Authentication group context
src/main/java/com/cotato/cokerthon/domain/auth/dto/response/AuthResponse.java, src/main/java/com/cotato/cokerthon/domain/auth/service/AuthService.java, src/main/java/com/cotato/cokerthon/domain/group/repository/GroupMemberRepository.java
Authentication responses include group IDs, which are queried during login; signup returns an empty group list.

Chore listing API

Layer / File(s) Summary
Chore listing flow
src/main/java/com/cotato/cokerthon/domain/chore/..., src/main/java/com/cotato/cokerthon/global/config/SwaggerConfig.java
Adds a read-only /api/chores endpoint that maps chores to ChoreResponse records and registers the route in the chore OpenAPI group.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant AuthService
  participant AuthenticationManager
  participant GroupMemberRepository
  Client->>AuthService: login credentials
  AuthService->>AuthenticationManager: authenticate credentials
  AuthenticationManager-->>AuthService: authenticated member
  AuthService->>GroupMemberRepository: findByMember(member)
  GroupMemberRepository-->>AuthService: group memberships
  AuthService-->>Client: AuthResponse with groupIds
Loading
sequenceDiagram
  participant Client
  participant ChoreController
  participant ChoreService
  participant ChoreRepository
  Client->>ChoreController: GET /api/chores
  ChoreController->>ChoreService: getAllChores()
  ChoreService->>ChoreRepository: findAll()
  ChoreRepository-->>ChoreService: chore entities
  ChoreService-->>ChoreController: ChoreResponse list
  ChoreController-->>Client: CommonResponse
Loading

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/signup

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant