Fix Swagger API server URL - #9
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughSwagger server URLs are now configurable through environment-specific properties, injected into ChangesSwagger server URL configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ApplicationConfig
participant SwaggerConfig
participant OpenAPI
ApplicationConfig->>SwaggerConfig: inject app.swagger.server-url
SwaggerConfig->>SwaggerConfig: validate http or https scheme
SwaggerConfig->>OpenAPI: add validated server URL
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ccjngwn
marked this pull request as ready for review
July 10, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http://orhttps://API origin.app.swagger.server-url.Root cause
Updating
CORS_ALLOWED_ORIGINSalone does not change the request URL generated by Swagger UI. When Swagger resolves an invalid or scheme-less API server URL, the browser reportsFailed to fetchwithURL scheme must be "http" or "https" for CORS request.Validation
./gradlew testSummary by CodeRabbit
New Features
Bug Fixes