Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub: drop custom recipe and migrate to the upstream grub-efi version #242

Merged
merged 4 commits into from
Jun 1, 2018

Conversation

rsalveti
Copy link
Contributor

Migrate to the upstream grub-efi recipe instead of maintaining a fork as that is causing conflicts with several other layers (e.g. issue #240).

rsalveti added 4 commits May 31, 2018 18:32
Instead of duplicating an entire recipe which is now older than what is
provided via OE-core, drop the current recipe (grub-git) in favor of the
upstream grub-efi (2.02) version.

Upstream is mostly in sync with grub-git, only missing piece is the grub
cfg customization, which is currently replaced via an extra grub-mkimage
call.

Signed-off-by: Ricardo Salveti <[email protected]>
Depend on grub-efi instead of grub, as that is the upstream recipe
responsible for deploying the EFI grub image.

Signed-off-by: Ricardo Salveti <[email protected]>
Depend on grub-efi instead of grub, as that is the upstream recipe
responsible for deploying the EFI grub image.

Signed-off-by: Ricardo Salveti <[email protected]>
Depend on grub-efi instead of grub, as that is the upstream recipe
responsible for deploying the EFI grub image.

Signed-off-by: Ricardo Salveti <[email protected]>
@rsalveti
Copy link
Contributor Author

Only tested with hikey, but it should work the same way with the other targets.

@rsalveti
Copy link
Contributor Author

Will also propose the remaining changes upstream, but this should at least unblock the issue.

@fboudra fboudra requested review from koenkooi and fboudra June 1, 2018 06:49
Copy link
Member

@fboudra fboudra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsalveti
Copy link
Contributor Author

rsalveti commented Jun 1, 2018

@koenkooi mind having a look? Thanks!

@fboudra fboudra merged commit 200a756 into 96boards:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants