Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hikey970 yocto support #272

Open
wants to merge 1 commit into
base: rocko
Choose a base branch
from

Conversation

nishantpoorswani
Copy link
Contributor

Added necessary files for Hikey970 including machine conf, bsp and kernel.

@rsalveti
Copy link
Contributor

Can you propose to master first and then backport to rocko instead?

@fboudra fboudra requested review from koenkooi and fboudra September 24, 2018 15:01
@nishantpoorswani
Copy link
Contributor Author

@rsalveti should I send a separate pull request for master?

@fboudra
Copy link
Member

fboudra commented Sep 26, 2018

@nishantpoorswani you should resubmit the PR against the master branch. Yes, it will be a separate PR.

@nishantpoorswani
Copy link
Contributor Author

@fboudra is it possible to review and merge(if fine) to rocko first and then do another pr with changes for master?

@nishantpoorswani
Copy link
Contributor Author

@fboudra and @rsalveti I've sent another pr with changes for the master branch like you'll suggested. Is it possible to review it.

@fboudra
Copy link
Member

fboudra commented Oct 2, 2018

@nishantpoorswani I'll review it later today.

@nishantpoorswani
Copy link
Contributor Author

Thanks @fboudra 

@nishantpoorswani
Copy link
Contributor Author

nishantpoorswani commented Oct 8, 2018

@fboudra Did you get a chance to review the pr for master?#274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants