gstreamer1.0-libav_%.bbappend: disable thumb for armv7a #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On am5728-evm board, if thumb is enabled, an attempt to play an h264-encoded video fails with: "illegal instruction in libgstlibav.so, ff_h264_idct_dc_add_neon()” Signed-off-by: Andrey Konovalov <[email protected]>
ndechesne
reviewed
Jan 22, 2019
| @@ -0,0 +1,2 @@ | |||
| # Disable thumb | |||
| ARM_INSTRUCTION_SET_armv7a = "arm" | |||
There was a problem hiding this comment.
if we do it, we should do it for rpb distro only. if it's a bug upstream then it should be dicussed on oe-core list.
There was a problem hiding this comment.
There are some more details like gdb log snippets under https://projects.linaro.org/browse/MMWG-79 . I would appreciate if people go and take a look.
I am not familiar enough with thumb, and can't tell if the illegal instruction is due to a bug upstream, or due to e.g. the SOC hw bug (my am57xx-evm is fairly early revision, but I am not aware of any errata like that). And I don't have other armv7 boards handy. Hm.. maybe checking db410c with a 32-bit rootfs could make sense before posting to oe-core list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On am5728-evm board, if thumb is enabled, an attempt to play an h264-encoded
video fails with:
"illegal instruction in libgstlibav.so, ff_h264_idct_dc_add_neon()”
Signed-off-by: Andrey Konovalov [email protected]