New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes: #45 [WIP] add more test cases #46

Closed

isuruAb wants to merge 1 commit into 99x:master from isuruAb:45

Contributor

isuruAb commented Sep 1, 2017

Fixes issue #45
Changes: added more test cases


          fixes: 99x#45 add more test cases

dinukadesilva reviewed

View reviewed changes

test/initialize.js

+                it("should initialize react app with git repository with eslint configuration", function (done) {
+                  init.initialize("../test-project", 'https://github.com', true, function (result) {
+                    rmdir("../test-project", err => {
+                      if (err) throw new Error("failed");

dinukadesilva Sep 1, 2017

Using 'assert.fail' would be ideal than throwing an exception explicitly

http://chaijs.com/api/assert/#method_fail

isuruAb closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet