-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases not completely fair #41
Comments
Ok, I see how I got it a bit wrong. The results table mentions inline styles, so perhaps the test case is not wrong but I consider it misleading. I don't really see the point of comparing a fully dynamic class creation (like in the |
I think there's a naming problem. I also got misled by the results stating that What I had to check myself, however, was the case of many static
Thanks for this great repo anyway, it saved me a LOT of time + your bootstrap was so easy to extend with what I wanted. |
The emotion css-mode test is not actually using emotion for colouring of the cells, which is the heaviest part. It just uses inline styles:
style={{ background: `rgba(74, 174, 53, ${x})` }}
which has to be super quick.
Instead, it should be using class generation like the glamorous/glamor-css test does.
I can submit a PR to fix this. It considerably changes the results table.
The text was updated successfully, but these errors were encountered: