Dynamic class generation cases for emotion, cxs and aphrodite #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrej
changed the title
|
Just out of curiosity, how did those libs perform? |
|
@streamich Here are the results: emotion and cxs still doing well I'll have to rerun it, though. Some tests returned NaN If you're interested in other benchmarks, these look interesting: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
This PR adds test cases for dynamic class generation for emotion (css-mode), cxs and aphrodite. Essentially, each existing case has been split into dynamic and inline styles version.
I intentionally didn't include the updated results table. Please let me know if it should be included. Or I can create a separate PR for that.
Once this is merged it would be good to upgrade packages to the latest versions.