Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing doc-pagefooter and doc-pageheader roles #549

Merged

Conversation

jlp-craigmorten
Copy link
Contributor

@jlp-craigmorten jlp-craigmorten commented Apr 1, 2024

Resolves #552

Adds two missing roles for doc-pagefooter and doc-pageheader from the dpub-aria specification

See:

Copy link

codesandbox-ci bot commented Apr 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@coveralls
Copy link

coveralls commented Apr 1, 2024

Pull Request Test Coverage Report for Build 9833633133

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.491%

Totals Coverage Status
Change from base Build 9833620982: 0.02%
Covered Lines: 285
Relevant Lines: 289

💛 - Coveralls

@ljharb ljharb force-pushed the fix-add-missing-doc-page-sections branch from 9221cea to 376caf7 Compare July 8, 2024 04:39
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be arguably a semver-minor, but I'll take your recommendation and consider it a patch.

@ljharb ljharb merged commit 376caf7 into A11yance:main Jul 8, 2024
7 checks passed
@jlp-craigmorten jlp-craigmorten deleted the fix-add-missing-doc-page-sections branch July 8, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing doc-pagefooter and doc-pageheader from the dpub-aria specification
3 participants