Skip to content

Version 0.0.2 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Version 0.0.2 #4

wants to merge 8 commits into from

Conversation

LinkunGao
Copy link

  • create obj/mtl module loader
  • create progressing bar
  • create gltf/glb module loader

@LinkunGao
finish build the initial structure, and build a upload image function…
fbfb836 
…, you can check it in app/example_01
@LinkunGao
Add loadObjFile function
d60215a 
- we can use .obj file url to load module, more details see example_02
- add light control into gui
- the camera position now is fixed, it cannot be fit different module size automatically, next version I may consider to fix it.
@LinkunGao
add loading bar
0452820
@LinkunGao
Finish the mtl file loader, --- see example03
bc15ea4
@LinkunGao
Create GLTF/GLB json module file loader
e456d48 
- see example04
- add renderer setting into gui controler
- there are some code need to reuse, we can fix it in next version
@chinchien-lin
Copy link

Looks awesome thanks @LinkunGao!!

@chinchien-lin
Copy link

chinchien-lin commented Dec 6, 2021 •
edited
Loading

seems that the first example (example_01_uploadImage) is not working? Would you mind double-checking if it is working on your side? might be because of the version of threejs/amijs?

Apart from the first example, others are working great!

@chinchien-lin
Copy link

chinchien-lin commented Dec 6, 2021 •
edited
Loading

Other notes:

  • Would you be able to remove the system files such as the .DS_Store file from the commits. Please also add them to .gitignore
  • Might be good to manually download the threejs and amijs libraries and push them as well just in case something happens to the import links in the future, or in case they would be no longer available... (it actually happened on some libraries...)

@LinkunGao
Copy link
Author

LinkunGao commented Dec 6, 2021 via email

@chinchien-lin chinchien-lin self-requested a review December 6, 2021 22:15
@chinchien-lin
Copy link

chinchien-lin commented Dec 6, 2021 •
edited
Loading

@LinkunGao Also, it would be awesome if you could also add some docstrings to the functions/classes?

@LinkunGao
Copy link
Author

@LIN810116 for the documentation, I've already written some short descriptions in the readme file, I will write it more clear next time.

@chinchien-lin
Copy link

chinchien-lin commented Dec 6, 2021 •
edited
Loading

@LIN810116 for the documentation, I've already written some short descriptions in the readme file, I will write it more clear next time.

Hi @LinkunGao,

Oh I mean the function docstrings. have a look at this: https://en.wikipedia.org/wiki/Docstring#JavaScript

@LinkunGao
Migrate whole project to webpack
5b83199 
- how to run project and see example: (1)npm install,(2)npm run serve
- build webpack environment
- config babel.js, when we run build converting high-level JS/ES6 syntax into low-level code for greater code compatibility.
- config webpack, now we can run serve at 127.0.0.1:3000, and config webpack each loader and plugins so we can import css less scss glb/gltf obj mlt and image files.
- there are only three load modules function works, .obj,.mlt,.gltf/.glb
- the ami.js is not work, the error is same to its official example error.
- if I have the correct ami.js documentation with it's version, I think I can work very fast.
- next step: focus on JS docstring, load multiple dicom images if the ami.js is work, make more interaction with gui, Integrating code to make it more object-oriented.
@chinchien-lin
Copy link

Hi @LinkunGao ,

The load model examples are working. Well done!

Just a few small things:

  • Would you be able to increase the brightness of the model in example 2 a little bit?
  • Do you have any ideas of why there are some errors/warning messages showing on the developer console? Would be great if could also address/remove these
    image

@LinkunGao
Copy link
Author

Thank you Chinchien,
I will manage to fix that errors in the console. And for example 2 is because the webpack cannot read the texture URL in .mtl file, I will try to fix that later.

@LinkunGao
Add load dicom function
16eba9c 
- build example04 to display load dicom
- change the project structure
@LinkunGao
Fix some bugs
0977921 
- the error 'cannot read width' in the console may due to the webpack config setting has something wrong, I will check it later
- there is a new challenge is about when we upload different dicom images, we must reset the camera positions. I also try to use camera lookAt function, but it doesn't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinchien-lin chinchien-lin Awaiting requested review from chinchien-lin

@PrasadBabarendaGamage PrasadBabarendaGamage Awaiting requested review from PrasadBabarendaGamage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinkunGao @chinchien-lin