Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited text in bgc_ocean.md #382

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Edited text in bgc_ocean.md #382

merged 4 commits into from
Jul 19, 2023

Conversation

heidinett
Copy link
Contributor

Edited text in the bgc_ocean.md of Model Components on the ACCESS-Hive.

@matt-csiro - Are there any other more-relevant links for WOMBAT?

Fixes Issue #379

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

PR Preview Action v2.1.1
🛫 Deployed preview to https://access-hive.github.io/pr-preview/pr-382/
on branch gh-pages at 2023-07-19 22:10 UTC

@KAUR1984
Copy link
Contributor

KAUR1984 commented Jul 6, 2023

Can be closed once merged.

@aidanheerdegen aidanheerdegen requested review from matt-csiro and removed request for aidanheerdegen July 13, 2023 00:11
Copy link

@matt-csiro matt-csiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the description of NPZD fits better in the "WOMBAT" section, and please mention CSIRO here, I suggest the following modifications:

"The World Ocean Model of Biogeochemistry And Trophic-dynamics (WOMBAT) is the ocean biogeochemistry module added to ACCESS models. The core of WOMBAT is a Nutrient, Phytoplankton, Zooplankton and Detritus (NPZD) cycle. WOMBAT simulates the evolution of open-ocean phosphate, oxygen, dissolved inorganic carbon, alkalinity, iron and carbon fluxes with one zooplankton and one phytoplankton class."

Under "How is WOMBAT used?"...
Yes, "WOMBAT is applied as a tracer package in MOM5." (shift reference to NPZD to previous section)
There are two implementations that could be referred to here for clarity.
Perhaps,
"WOMBAT in [link to COSIMA MOM5 repository, https://github.com/mom-ocean/MOM5] is used in ACCESS-OM2, coupled with sea ice BGC, and,
WOMBAT in [link to https://github.com/COSIMA/ACCESS-ESM1.5-MOM5] is used for ACCESS-ESM1.5 for CMIP6."

Hope this helps,
Cheers, Matt.

@heidinett
Copy link
Contributor Author

Thanks @matt-csiro for your feedback and suggestions! I have incorporated these into the text.
Could you please check what I wrote is correct.

Cheers,
Heidi

Copy link
Contributor

@KAUR1984 KAUR1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the changes @heidinett !

@KAUR1984 KAUR1984 merged commit 32c3a75 into development Jul 19, 2023
2 checks passed
@KAUR1984 KAUR1984 deleted the dev/heidi/issue379 branch July 19, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants