Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models index.md: Updated shortened config descriptions and flow diagram #471

Merged
merged 18 commits into from
Jul 28, 2023

Conversation

heidinett
Copy link
Contributor

@heidinett heidinett commented Jul 24, 2023

Models index.md: Updated shortened config descriptions and flow diagram

Fixes Issue #465

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

PR Preview Action v2.1.1
🛬 Preview removed because the pull request was closed.
2023-07-28 05:00 UTC

removed image resize comment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this image has the whit background?
The images should be all with transparent background.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the titles have white background.
They should not have any background.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this image, but I think all rectangles (both model components and the experiment one) should have rounded corners (in line with the model configuration rectangle and all the other elements on the website)

corrected the path of new access-am figure
fixed typo in OM label
corrected the path of new access-am figure
corrected the path of new access-cm figure
corrected the path of new access-esm figure
replaced earth with Earth in opening paragraph.
Copy link
Contributor

@KAUR1984 KAUR1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heidinett for the pr.

I surely agree with the all the suggestions made by @atteggiani, and they are discussed in the weekly team meeting. Approving this pr so we have these images as the starting point on hive , and they would need to changed in the near future :)

@KAUR1984 KAUR1984 merged commit 559bd66 into development Jul 28, 2023
2 checks passed
@KAUR1984 KAUR1984 deleted the dev/heidi/issue465 branch July 28, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants