-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Models index.md: Updated shortened config descriptions and flow diagram #471
Conversation
|
…ub.io into jasmeen/tune-hive-images-435
removed image resize comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this image has the whit background?
The images should be all with transparent background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the titles have white background.
They should not have any background.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this image, but I think all rectangles (both model components and the experiment one) should have rounded corners (in line with the model configuration rectangle and all the other elements on the website)
corrected the path of new access-am figure
fixed typo in OM label
corrected the path of new access-am figure
corrected the path of new access-cm figure
corrected the path of new access-esm figure
replaced earth with Earth in opening paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @heidinett for the pr.
I surely agree with the all the suggestions made by @atteggiani, and they are discussed in the weekly team meeting. Approving this pr so we have these images as the starting point on hive , and they would need to changed in the near future :)
Models index.md: Updated shortened config descriptions and flow diagram
Fixes Issue #465