Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated How to run ACCESS-ESM with new repo #637

Merged
merged 11 commits into from
Feb 6, 2024
Merged

Updated How to run ACCESS-ESM with new repo #637

merged 11 commits into from
Feb 6, 2024

Conversation

atteggiani
Copy link
Contributor

  • Updated how to run ACCESS-ESM, using the updated GitHub Repo

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2024 •
edited
Loading

PR Preview
🛬 Link removed because the pull request was closed.
2024-02-06 14:40 AEDT

@atteggiani atteggiani changed the title Updated How to run ACCESS-ESM with new repoå Updated How to run ACCESS-ESM with new repo Jan 11, 2024
heidinett
heidinett reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@heidinett heidinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor edits to the text required. See comments in relevant sections.

@atteggiani
Copy link
Contributor Author

Thank you for the review @heidinett!

This was referenced Jan 12, 2024
Closed
Closed
ccarouge
ccarouge requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commented beyond the modifications of this PR. So some of the comments might be hard to localise since I couldn't attach them to a code change. Happy to discuss if you need help understanding what I am referring to.

docs/models/run-a-model/run-access-esm.md Outdated Show resolved Hide resolved
docs/models/run-a-model/run-access-esm.md Outdated Show resolved Hide resolved
docs/models/run-a-model/run-access-esm.md Show resolved Hide resolved
docs/models/run-a-model/run-access-esm.md Show resolved Hide resolved
docs/models/run-a-model/run-access-esm.md Outdated Show resolved Hide resolved
docs/models/run-a-model/run-access-esm.md Outdated Show resolved Hide resolved
@atteggiani atteggiani requested review from ccarouge and removed request for ccarouge January 22, 2024 02:41
@atteggiani
Copy link
Contributor Author

Thank you @ccarouge for the review.

I have addressed all the comments and commented on the ones I haven't or changed your suggestions.

If you think it's ok to merge I'll merge it.

@atteggiani atteggiani requested review from penguian, MartinDix and ccarouge and removed request for ccarouge, penguian and MartinDix January 30, 2024 02:54
ccarouge
ccarouge approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

Sorry for the slow turn around on this.

@atteggiani atteggiani merged commit 464a674 into development Feb 6, 2024
8 of 9 checks passed
@atteggiani atteggiani deleted the davide/update-how-to-run-access-esm branch February 6, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heidinett heidinett heidinett left review comments

@ccarouge ccarouge ccarouge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atteggiani @ccarouge @heidinett