Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added persistent sessions to 'How to run ACCESS-CM' page #649

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Added persistent sessions to 'How to run ACCESS-CM' page #649

merged 5 commits into from
Feb 12, 2024

Conversation

atteggiani
Copy link
Contributor

@atteggiani atteggiani commented Jan 30, 2024 •
edited
Loading

Updated 'How to run ACCESS-CM' page with the new persistent session workflow.
Completed removed accessdev workflow and added some instructions to try and port a suite from accessdev to persistent sessions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

PR preview
⚠️ There was an error in the pr-preview deployment. For more information, please check the Actions tab.
2024-02-12 16:41 AEDT

@atteggiani atteggiani requested review from penguian and MartinDix and removed request for penguian January 30, 2024 02:55
@atteggiani
Copy link
Contributor Author

atteggiani commented Jan 30, 2024 •
edited
Loading

@MartinDix @heidinett
For the review, the main sections that changed are:
Setup ACCESS-CM persistent session and Port suites from accessdev

heidinett
heidinett requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@heidinett heidinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Davide!
I made only some minor edit suggestions where applicable.

@atteggiani
Update run-access-cm.md
01476c3 
Updates after Heidi's review
@atteggiani atteggiani requested review from heidinett and removed request for MartinDix and heidinett February 12, 2024 03:53
heidinett
heidinett approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@heidinett heidinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Davide! I left a few suggested edits. Feel free to accept or reject these.

@atteggiani
Copy link
Contributor Author

Thank you @heidinett.

Merging now.

@atteggiani atteggiani merged commit c02c3f6 into development Feb 12, 2024
2 of 4 checks passed
@atteggiani atteggiani deleted the davide/persistent-sessions branch February 12, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heidinett heidinett heidinett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atteggiani @heidinett