-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update titles under "Getting Started" section #717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall we can improve many sections' titles and how we structure/frame each of the sessions.
So, thank you @paigem for opening this PR and starting this conversation!
For the specific changes please see the comments under each of those.
Note on the PR and the GitHub actions:
- You started this PR from your fork of this repo, instead of creating a branch directly inside the repo. Is there any specific reason why you chose this approach? In general this is completely fine (and is the recommended approach for an external person that wants to contribute directly) but since you are a member of ACCESS-NRI it might be easier to just create your own branch within the repo itself.
- The
Deploy to GitHub Pages
action for this PR failed (deployment and PR comment). I am not completely sure why yet, but I guess it has to do with GITHUB_TOKEN permission within the GitHub workflow (most likely because you started the PR from a fork). This of course has nothing to do with you and it's something we need to fix so it doesn't happen for external people. I rasied an issue and I'll have a look into that. - You opened the PR to be merged into
ACCESS-NRI:main
, but the correct branch for merging PRs isACCESS-NRI:developent
. You might have followed the Contribute on GitHub guide on the Hive Docs and, in fact, I checked but there is no mention of which branch to select when opening PRs.
I changed the target branch fromACCESS-NRI:main
toACCESS-NRI:development
and I raised an issue to update the instructions on the Hive Docs.
Thank you!!
Co-authored-by: Davide Marchegiani <[email protected]>
Thanks @atteggiani for your review! I have a few responses below and have also commented directly on your suggested edits.
|
That is completely fine and if you are used to that workflow I think there shouldn't be any problems.
No I am pretty confident this is not your fault. It might be related to your PR coming from an external fork instead of an internal branch, but I still do not know why that happens. In any case, this should NOT happen, and will have to be fixed within the deployment workflow. This PR is perfectly fine.
Yeah, no problem! git fetch upstream -Pp
git checkout <your-feature-branch>
git rebase upstream/development # you can also use 'git merge' but I prefer 'git reabase'
# You might need to resolve conflicts generated by the rebase/merge
git push |
Based on our discussion during our meeting, we can use the phrase "New ACCESS user?" We should also add a sentence or two on the "Getting Started" page to add a bit of text around what is needed for new ACCESS users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paigem, I'll approve and merge once those couple things are done
Co-authored-by: Felicity Chun <[email protected]>
Discussed in meeting 20th August 2024
Description
This PR updates the titles in the
Getting Started
section. I've made some suggestions here, and would like input from the Hive Docs Team on whether these updated titles make sense.I tried to update the titles in all locations, including the navigation bar and homepage, but please let me know if I missed anywhere.
Fixes #716
Type of change
Please delete options that are not relevant.
Checklist: