Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ (#693): Fixed the copyright year to 2024 #736

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

KAUR1984
Copy link
Contributor

@KAUR1984 KAUR1984 commented Aug 26, 2024

Fixes the issue #693


@KAUR1984 KAUR1984 added the ✨UI Improvements or additions to the UI label Aug 26, 2024
@KAUR1984 KAUR1984 requested a review from a team August 26, 2024 23:57
@KAUR1984 KAUR1984 self-assigned this Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

PR preview
🛬 Preview link removed because the pull request was closed.

Copy link
Contributor

@atteggiani atteggiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jasmeen.

Looks good and I approved.
Just a note: I think we discussed already adding a JS function that automatically gets the year for the copyright, so we don't have to change it every year.
I think this needs to be carried out to avoid other similar problems appearing every year.

I am happy to merge this as it is currently, or instead wait until the JS function has been implemented.

What do you think?

@atteggiani atteggiani force-pushed the jasmeen/change-copyright-year-693 branch from c32d1ce to 5fbf83c Compare August 27, 2024 01:43
@atteggiani
Copy link
Contributor

Branch has been rebased with development

@KAUR1984
Copy link
Contributor Author

Thanks @atteggiani ! I agree with using a JS function for the copyright year. I will work on the other high priority issues for now, and will come back to this afterwards. :)

@atteggiani atteggiani merged commit 23d6d3d into development Aug 27, 2024
6 of 7 checks passed
@atteggiani
Copy link
Contributor

I will then merge it as it is, and create another issue to add the JS function.
That issue can be worked on even after the workshop.

@atteggiani atteggiani deleted the jasmeen/change-copyright-year-693 branch September 4, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨UI Improvements or additions to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants