Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from MOM6-CICE6 #24

Merged
merged 4 commits into from
May 10, 2024

Conversation

anton-seaice
Copy link

No description provided.

@anton-seaice
Copy link
Author

I believe this is correct, but we need to merge #23 first to confirm.

@anton-seaice anton-seaice marked this pull request as ready for review April 23, 2024 00:50
Copy link

@ezhilsabareesh8 ezhilsabareesh8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fsd related parameters are required in MOM6-CICE6-WW3 configurations, for example, tr_fsd shouldn't be removed from ice_in unless it is true by default.

@anton-seaice
Copy link
Author

Oops. Thanks. Ill fix tomorrow.

I can't see any other mistakes - all the fsd history parameters are unchanged ?

@ezhilsabareesh8
Copy link

ezhilsabareesh8 commented May 2, 2024

all the fsd history parameters are unchanged ?

The following history parameters are unchanged, however restart_fsd = .false. is ommited not sure what it actually does

&icefields_fsd_nml
    f_fsdrad       = 'md' 

@anton-seaice
Copy link
Author

Ok thanks - yes we need that too to get it to read fsd from the cice restart file!

https://cice-consortium-cice.readthedocs.io/en/main/user_guide/ug_case_settings.html#tracer-nml

@anton-seaice anton-seaice force-pushed the 1deg_jra55do_iaf_iss106 branch 2 times, most recently from 861904d to 0c102b6 Compare May 3, 2024 04:03
Copy link

@ezhilsabareesh8 ezhilsabareesh8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it is ok to use the same initial conditions for both the RYF and IAF configurations?, It's the same in MOM6-CICE6 configs as well.

ice_ic = "./input/iced.1900-01-01-10800.nc"

@anton-seaice
Copy link
Author

Yeah I think that is fine. Its not perfect. But the ice will be kinda of close, and the ice will stabilise much quicker than the ocean will. So it seems ok from that perspective.

Copy link

@ezhilsabareesh8 ezhilsabareesh8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@anton-seaice
Copy link
Author

Ah. This doesn't run anymore:

 (abort_ice)ABORTED: 
 (abort_ice) called from ice_restart.F90
 (abort_ice) line number          744
 (abort_ice) error = 
 (ice_pio_check)NetCDF: Variable not found, (read_restart_field) ERROR: missing 
 varid fsd001

Because our ic file doesnt include fsd

We must have missed this in the RYF config too.

(Not sure how to make the best fsd initial conditions, or whether to fix this some other way!)

@ezhilsabareesh8 ezhilsabareesh8 self-requested a review May 3, 2024 05:23
@ezhilsabareesh8
Copy link

(Not sure how to make the best fsd initial conditions, or whether to fix this some other way!)

Maybe we can set the ice_ic to default for now?, I think fsd initial conditions cannot be generated from CICE5?

We must have missed this in the RYF config too.

Yes, restart_fsd is set to false in RYF.

@anton-seaice
Copy link
Author

I think setting ice_ic to default would be troublesome, it gives a very unrealistic ice area. We could leave restart_fsd as false and create a new issue to resolve it.

@anton-seaice
Copy link
Author

anton-seaice commented May 8, 2024

Ah. It looks like restart_fsd=.false. was correct. If the runtype is continue, this gets turned on in the driver, otherwise it initialises internally:

https://github.com/CICE-Consortium/CICE/blob/0af031d785d3bc622cd19af48a2e9465b5abe9a0/cicecore/drivers/nuopc/cmeps/CICE_InitMod.F90#L373

@ezhilsabareesh8
Copy link

This doesn't run anymore:

(abort_ice)ABORTED: (abort_ice) called from ice_restart.F90 (abort_ice) line number 744 (abort_ice) error = (ice_pio_check)NetCDF: Variable not found, (read_restart_field) ERROR: missing varid fsd001

But when you set restart_fsd = true, you're getting the above missing variable error right?

! floe size distribution if (tr_fsd) then if (trim(runtype) == 'continue') restart_fsd = .true. if (restart_fsd) then call read_restart_fsd

According to the above code even when we set restart_fsd = .true., it should run right? "

@anton-seaice
Copy link
Author

If runtype=initial (and restart_fsd=.false.) then it will initialise fsd using the init_fsd call

If runtype=continue or restart_fsd=.true. in ice_in, then it will try to read fsd from the restart/ic file

anton-seaice and others added 4 commits May 10, 2024 13:43
* Copy OM2 CICE Config

* updates for icefields which are on by default

Cherry-picked from MOM6-CICE6 c45fb289997d82a719b4edc44ab9f2edd729d16e

+ ensure fsd is on
@anton-seaice
Copy link
Author

This works and generates output and history files for each component. Doesn't restart due to still pointing to a binary before COSIMA/access-om3#160 was included

@anton-seaice anton-seaice merged commit 58c5f9a into 1deg_jra55do_iaf May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants