Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Minor) Fix capturing logs in tests #3011

Merged
merged 2 commits into from
Feb 24, 2025
Merged

(Minor) Fix capturing logs in tests #3011

merged 2 commits into from
Feb 24, 2025

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Feb 19, 2025

The lack of properly initialized MDCContext made prepareForDeferredProcessing() crash in MyCapturingAppender.

pm47 added 2 commits February 19, 2025 10:06
@pm47
fix capturing logs
5e314e0 
The lack of properly initialized `MDCContext` made
`prepareForDeferredProcessing()` crash in `MyCapturingAppender`.
@pm47
use context dependent MDC instead of global one
1e60a8d
@pm47 pm47 requested a review from t-bast February 21, 2025 18:38
t-bast
t-bast approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with one of the OfferPaymentSpec test, that seems to work 👍

@pm47 pm47 merged commit 22bc4a7 into master Feb 24, 2025
1 check passed
@pm47 pm47 deleted the fix-capturing-logs branch February 24, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pm47 @t-bast