Use testnet4 for electrum tests instead of testnet3 #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
reviewed
Nov 27, 2024
| @@ -5,12 +5,12 @@ import fr.acinq.lightning.tests.utils.testLoggerFactory | |||
| import fr.acinq.lightning.utils.ServerAddress | |||
| import kotlinx.coroutines.CoroutineScope | |||
|
|
|||
| val ElectrumTestnetServerAddress = ServerAddress("testnet1.electrum.acinq.co", 51002, TcpSocket.TLS.UNSAFE_CERTIFICATES) | |||
| val ElectrumTestnet4ServerAddress = ServerAddress("mempool.space", 40002, TcpSocket.TLS.TRUSTED_CERTIFICATES()) | |||
There was a problem hiding this comment.
I don't understand, mempool.space also acts as an electrum server?
There was a problem hiding this comment.
Yes (testnet4 on port 40002, mainnet on 50002).
t-bast
previously approved these changes
Nov 27, 2024
TLS certificare verification fails on iOS simulators with error "TLS: -9808: bad certificate format".
t-bast
approved these changes
Nov 27, 2024
They use of fork of Blokckstream's electrs (which is a fork of the original electrs project). This is probably what we would use if we were to deploy a testnet4 server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testnet3 is bloated, slow and unreliable, making it hard to use for CI tests.