Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer mode #148

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Timer mode #148

merged 5 commits into from
Nov 22, 2023

Conversation

dylwhich
Copy link
Collaborator

Description

Simple timer mode, has stopwatch and countdown modes. Keeps previous time saved in NVS at exit.

Test Instructions

A starts/resumes, B stops/resets, up/down change the set time, and left/right change between stopwatch and timer.

Ticket Links

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@AEFeinstein
Copy link
Owner

Just from testing, not from looking at the code, two comments

  1. The text is off-center. Please align that for my OCD
  2. The test instructions on the PR are great, but having them on the display would be even greater. I can figure out the controls by playing with it, but instruction labels (like in Jukebox or Tunernome) are really nice and welcoming

assets/timer/hourglass_00.png Outdated Show resolved Hide resolved
main/modes/timer/modeTimer.c Outdated Show resolved Hide resolved
main/modes/timer/modeTimer.c Show resolved Hide resolved
main/modes/timer/modeTimer.c Show resolved Hide resolved
main/modes/timer/modeTimer.c Show resolved Hide resolved
main/modes/timer/modeTimer.c Outdated Show resolved Hide resolved
@dylwhich
Copy link
Collaborator Author

Okay, I think everything has been addressed now. Here's the new look:

image

Copy link
Owner

@AEFeinstein AEFeinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is infinitely more useable. I'm gonna merge this now, but I'll casually mention two stretch goals if you're feeling stretchy

  1. Some sort of buzzer and/or LED indication when the timer runs out
  2. Finer-grain increments for the timer. You could do that thing where the longer you hold the button, the faster it increments, or it switches from 1s increments to 30s increments. I think that's how my stove timer works.

@AEFeinstein AEFeinstein merged commit 4a7669d into main Nov 22, 2023
1 check passed
@AEFeinstein AEFeinstein deleted the timer-mode-standalone branch November 22, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants