Skip to content

Create pull request template #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nolanhergert wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create pull request template #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d33755
Initial proposal
nolanhergert Oct 16, 2024
a1410ae
Require approval by systems conference
nolanhergert Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<summary>

<testing performed>



# Reviewer
[ ] Is this change approved by team systems conference?
[ ] Are hardware errors possible, and are they handled properly?
[ ] Do the changes affect end users (drive team), and have they tried the change / approve of it?
[ ] Was an on-robot basic test + functionality test run?

## Optional
[ ] Can some behavior be wrapped with some unit tests? (ensuring there are no regressions in the future)