Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(notebooks): Ignore Flake8 complaints on Notebooks #1053

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ns-rse
Copy link
Collaborator

@ns-rse ns-rse commented Dec 16, 2024

One (E712) is a false positive as its used to subset a Pandas DataFrame.

The other two I've no current alternative plan as they involve creating buttons for users to upload files. Not sure
whether these will persist past the notebook refactor (#943) so have disabled the checks for the time being.


Before submitting a Pull Request please check the following.

  • Pre-commit checks pass.

One (E712) is a false positive as its used to subset a Pandas DataFrame.

The other two I've no current alternative plan as they involve creating buttons for users to upload files. Not sure
whether these will persist past the notebook refactor (#943) so have disabled the checks for the time being.
@ns-rse ns-rse added this to the v2.3.0 milestone Dec 16, 2024
@ns-rse ns-rse added the v2.3.0 label Dec 16, 2024
@ns-rse ns-rse merged commit 1b45bea into main Dec 16, 2024
2 checks passed
@ns-rse ns-rse deleted the ns-rse/nbqa-fixes branch December 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants