tests(disordered_tracing): Bulks out missing unittests #978
Conversation
Making a start on the backlog/deficit of unit-tests highlighted in #966.
ns-rse
requested review from
SylviaWhittle,
MaxGamill-Sheffield and
llwiggins
| pytest.param((10, 10), [7, 7, 9, 9], 4, (3, 3), id="Simple square padded by 4 beyond bottom and right edges"), | ||
| ], | ||
| ) | ||
| def test_grain_anchor(array_shape: tuple, bounding_box: list, pad_width: int, target: npt.NDArray) -> None: |
There was a problem hiding this comment.
Is grain_anchor used anywhere? I pulled the branch and can't find any references to where it's used
There was a problem hiding this comment.
I'm not sure, I recall I introduced it because we needed a way of putting tracing, done on cropped grains, back into the original image and the solution I came up with was to have an anchor point so we could put it back in the right location.
If its been removed in the refactor in favour of an alternative method of putting everything back that is perfectly fine but there was too much in the code/pull request for me to spot that.
There was a problem hiding this comment.
Well it's tested and imo potentially useful so let's keep it. Was just wondering 😄
| @@ -21,7 +21,8 @@ | |||
|
|
|||
| LOGGER = logging.getLogger(LOGGER_NAME) | |||
|
|
|||
| # pylint: disable=too-many-positional-arguments | |||
| # too-many-positional-arguments | |||
| # pylint: disable=R0917 | |||
There was a problem hiding this comment.
Ah nice! I've been looking for a way to suppress this warning as the # pylint: disable=too-many-positional-arguments doesn't seem to work!
There was a problem hiding this comment.
Its quite annoying as its a valid name but doesn't seem to be recognised. I should raise an issue but still have to report to the Topoloy developers the issues with Python version releases and other problems uncovered the other day and don't have time for everything.
Making a start on the backlog/deficit of unit-tests highlighted in #966.