Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

3.0.0 #110

Merged
merged 22 commits into from
Apr 11, 2016
Merged

3.0.0 #110

merged 22 commits into from
Apr 11, 2016

Conversation

kcharwood
Copy link
Contributor

Merging the 3.0.0 branch to master.

@codecov-io
Copy link

Current coverage is 0.00%

Branch #110 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.

@kcharwood
Copy link
Contributor Author

@kylef @0xced @cnoon @jshier

I'd love a santity check review here. May be easier to pull the branch and just run git difftool master..HEAD AFOAuth2Manager/* since there is so much more project configuration noise migrating this to a framework based approach.

@jameshays
Copy link

Do we have an ETA on when this will be merged?

@kcharwood
Copy link
Contributor Author

My hope is soon. I've been out on vacation the last two weeks, and I'm at CES this week, so I haven't been able to close it out just yet. My goal is next week.

@kcharwood
Copy link
Contributor Author

If you need to pull this in via CocoaPods, you should be able to do something like:

pod 'AFOAuth2Manager', :git => 'https://github.com/AFNetworking/AFOAuth2Manager.git', :branch => '3_0_0_branch'

@jameshays
Copy link

Thanks @kcharwood. I'm building an extension off of this and will pull that branch in if it's that close to final merge. Thanks for your work on this!

@tblanchard
Copy link

Are we there yet?



@implementation AFOAuthCredential
//@dynamic expired;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented-out line should probably be removed

@beloso
Copy link

beloso commented Feb 25, 2016

Any news?

@dstranz
Copy link

dstranz commented Apr 6, 2016

@kcharwood Why you are not merging it?

@kcharwood
Copy link
Contributor Author

Merging this into a master! I'll let it simmer for 24 hours before pushing an official release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants