Update README.md #71
Open
Update README.md #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +31,7 @@ Lines starting with `*` are automatically rendered as bullet points and phrases | |||
| * Nevin Valsaraj [routeaccess](http://github.com/routeaccess) | |||
| * Prabhat Agarwal [prabhat1081](http://github.com/prabhat1081) | |||
| * Priyank Palod [priyankpalod](https://github.com/priyankpalod) | |||
| * Saransh Sharma [Saransh1Sharma] (http://github.com/Saransh1Sharma) | |||
There was a problem hiding this comment.
@Saransh1Sharma There isn't supposed to be a space between your username and url.
Also, please avoid writing a generic commit message.
Closed
|
@Saransh1Sharma Please change your commit message |
|
@Saransh1Sharma Your name is not in the final list because your PR isn't merged yet. Change the commit message using git commit --amend and your PR will be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.