Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facetIsDegenerated utility function #1214

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

MarkusFrankATcernch
Copy link
Contributor

BEGINRELEASENOTES

Copy link
Member

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

Test Results

    6 files      6 suites   4h 25m 8s ⏱️
  359 tests   355 ✅ 0 💤 4 ❌
1 061 runs  1 057 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 8721b2b.

@andresailer
Copy link
Member

Probably the epsilon too small, as you pointed out yesterday.
constexpr double epsilon = 1.e-20;

@MarkusFrankATcernch
Copy link
Contributor Author

No. It did not take into account negative determinants....

@MarkusFrankATcernch MarkusFrankATcernch enabled auto-merge (rebase) January 16, 2024 16:44
@MarkusFrankATcernch MarkusFrankATcernch merged commit 8add72e into AIDASoft:master Jan 16, 2024
11 of 13 checks passed
@andresailer
Copy link
Member

But it is failing tests related to ddcad...

@MarkusFrankATcernch
Copy link
Contributor Author

@andresailer Hell, screwed it again!
Could you unroll please? This is getting too complicated in git for me.
The only important thing is the std::fabs(...) in the return.

@MarkusFrankATcernch
Copy link
Contributor Author

@andresailer I do not get here any output on the failing slots:
https://github.com/AIDASoft/DD4hep/actions/runs/7544726687/job/20538715080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants