Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update which releases to test against #1242

Merged
merged 13 commits into from
Apr 18, 2024
Merged

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Mar 15, 2024

BEGINRELEASENOTES

  • CI: change which LCG_releases/ROOT versions DD4hep is tested.
  • Fix various issues with latest version of ROOT (6-32-patches, master) and cppyy in ROOT.
    • ⚠️ : You may encounter issues with python setup complaining about mismatched types, strings, conversions

ENDRELEASENOTES

Different errors encountered for better searching and finding in the future:
Mostly related to the change discussed here root-project/root#15153

1

350: Traceback (most recent call last):
350:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/bin/ddsim", line 25, in <module>
350:     sys.exit(RUNNER.run())
350:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/lib/python3.9/site-packages/DDSim/DD4hepSimulation.py", line 470, in run
350:     self.part.setupUserParticleHandler(part, kernel, DDG4)
350:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/lib/python3.9/site-packages/DDSim/Helper/ParticleHandler.py", line 146, in setupUserParticleHandler
350:     user.TrackingVolume_Zmin = str(-float(user.TrackingVolume_Zmax))
350: TypeError: float() argument must be a string or a number, not 'string'
350: corrupted size vs. prev_size in fastbins

Solution: In this case don't use properties obtained from the userHandler object, other cases might mean decoding the cppyy.gbl.std.string` or similar

2

294: Geant4Kernel     ERROR DDG4: The action ''UI'' is not globally registered. [Action-Missing]
294: Traceback (most recent call last):
294:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/examples/DDG4/scripts/TestUserCommands.py", line 107, in <module>
294:     run()
294:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/examples/DDG4/scripts/TestUserCommands.py", line 89, in run
294:     geant4.ui().applyCommand('/ddg4/Print/param interactive-2')
294:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/lib/python3.9/site-packages/DDG4.py", line 445, in ui
294:     return self.master().globalAction(ui_name)
294: cppyy.gbl.std.runtime_error: dd4hep::sim::Geant4Action* dd4hep::sim::Geant4Kernel::globalAction(const string& action_name, bool throw_if_not_present = true) =>
294:     runtime_error: Geant4Kernel: DDG4: The action ''UI'' is not globally registered. [Action-Missing]
294: corrupted size vs. prev_size in fastbins
294:  *** Break *** abort

Note the too many quotes ''UI'', solution again decoding the string returned from the cppyy object

3

279: Traceback (most recent call last):
279:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/examples/DDDigi/scripts/TestMultiInteractions.py", line 61, in <module>
279:     run()
279:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/examples/DDDigi/scripts/TestMultiInteractions.py", line 28, in run
279:     hist_drop = overlay.adopt_action('DigiHitHistoryDrop/Drop-1', masks=[evtreader.mask])
279:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/lib/python3.9/site-packages/dddigi.py", line 239, in _adopt_sequence_action
279:     setattr(action, option[0], option[1])
279:   File "/build/sailer/testDD4hep/dd4hep/dd4hepinstall/lib/python3.9/site-packages/dddigi.py", line 283, in _set
279:     if Interface.setProperty(act, nam, val):
279: cppyy.gbl.dd4hep.unrelated_value_error: static int dd4hep::digi::DigiActionCreation::setProperty(dd4hep::digi::DigiAction* action, const string& name, const string& value) =>
279:     unrelated_value_error: The type std::vector<int, std::allocator<int> > cannot be converted: Data conversion of [b'1'] to type 'std::vector<int, std::allocator<int> >' is not defined.

cppyy.gbl.std.string shows up in a list. Decoded all content inside lists.

Copy link

github-actions bot commented Mar 15, 2024

Test Results

   14 files     14 suites   6h 46m 19s ⏱️
  363 tests   362 ✅ 0 💤 1 ❌
2 496 runs  2 495 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 50aad89.

♻️ This comment has been updated with latest results.

@andresailer
Copy link
Member Author

I managed to create a standalone reproducer for the problem and raised the issue in the ROOT project.

DDG4/python/DDG4.py Outdated Show resolved Hide resolved
Avoid having another level of quotes or b'' showing up in the wrong places
@andresailer
Copy link
Member Author

andresailer commented Apr 16, 2024

I suspect the issue with clang16 is caused by how the compiler is created, and since it only affects tests where aclic is used, I propose to ignore these tests for the clang16 stack.

PS: adding setup-wrapper probably solves the issue... see next commit.
PPS: setup-wrapper was added to the dev3 setup.

@andresailer andresailer merged commit f233cea into AIDASoft:master Apr 18, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant