Fixed TwistedTube when only half-length is provided #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aviour when the value is used as 'half-length' replacing GetNegativeEndZ by GetPositiveEndZ fixes the problem because GetPositiveEndZ is the user value that corresponds to half-length
Test Results 7 files 7 suites 2h 53m 39s ⏱️ For more details on these failures, see this check. Results for commit 182b432. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
GetNegativeEndZmay be <0, leading to undefined behavior when the value is used as 'half-length'Replacing
GetNegativeEndZbyGetPositiveEndZin the Geant4 converting function fixes the problem becauseGetPositiveEndZcorresponds to the user value (that is expected to be the half-length of the twisted tube, as the half-length parameter of a regular tube)The change is tested in my local installation of DD4hep.
BEGINRELEASENOTES
ENDRELEASENOTES