Protect Geant4 Primary creation against negative masses. #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 14 files 14 suites 6h 31m 38s ⏱️ Results for commit 86b8743. ♻️ This comment has been updated with latest results. |
|
@atolosadelgado Hi Alvaro, |
andresailer
reviewed
May 7, 2024
| @@ -746,14 +746,24 @@ namespace dd4hep { | |||
| std::string refStr() const; | |||
| /// Access "module" attribute as STL string | |||
| std::string moduleStr() const; | |||
| /// Access "module" attribute as STL string | |||
There was a problem hiding this comment.
Suggested change
| /// Access "module" attribute as STL string | |
| /// Access "module" attribute as STL string, if not present return default_value |
andresailer
reviewed
May 7, 2024
| /// Access "readout" attribute as STL string | ||
| std::string readoutStr() const; | ||
| /// Access "readout" attribute as STL string |
There was a problem hiding this comment.
Suggested change
| /// Access "readout" attribute as STL string | |
| /// Access "readout" attribute as STL string, if not present return default_value |
andresailer
reviewed
May 7, 2024
| /// Access vis attribute as STL string. If not present empty return empty string | ||
| std::string visStr() const; | ||
| /// Access vis attribute as STL string. If not present empty return empty string |
There was a problem hiding this comment.
Suggested change
| /// Access vis attribute as STL string. If not present empty return empty string | |
| /// Access vis attribute as STL string, if not present return default_value |
andresailer
reviewed
May 7, 2024
| /// Access region attribute as STL string. If not present empty return empty string | ||
| std::string regionStr() const; | ||
| /// Access region attribute as STL string. If not present empty return empty string |
There was a problem hiding this comment.
Suggested change
| /// Access region attribute as STL string. If not present empty return empty string | |
| /// Access region attribute as STL string, if not present return default_value string |
andresailer
reviewed
May 7, 2024
| /// Access limits attribute as STL string. If not present empty return empty string | ||
| std::string limitsStr() const; | ||
| /// Access limits attribute as STL string. If not present empty return empty string |
There was a problem hiding this comment.
Suggested change
| /// Access limits attribute as STL string. If not present empty return empty string | |
| /// Access limits attribute as STL string, if not present return default_value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
examples/DDCAD/compact/DD4hep_Issue_1134_resolved.xml
Once the CAD shape (aka volume) is placed correctly into the origin of a mother mother, the mother can then be placed
rotated and shifted according to the the boxed mother's origin like any other volume.
ENDRELEASENOTES