Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geant4AssemblyVolume: use the same copy ID for the Geant4 Volume as w… #1362

Merged

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Dec 4, 2024

…as set in DD4hep geometry construction

BEGINRELEASENOTES

ENDRELEASENOTES

  • Check if this affects checksums or GDML output?
    • I don't think it can affect checksums, because those are calculated on the DD4hep/TGeo geometry
    • I didn't see any difference in the GDML ordering or copynumber tag in SiD gdml test

@andresailer andresailer force-pushed the fixAssemblyCopyNumber branch from a7db0e2 to 64f9566 Compare December 4, 2024 14:40
Copy link

github-actions bot commented Dec 4, 2024

Test Results

   14 files     14 suites   5h 36m 4s ⏱️
  368 tests   368 ✅ 0 💤 0 ❌
2 531 runs  2 531 ✅ 0 💤 0 ❌

Results for commit 4447c02.

@MarkusFrankATcernch MarkusFrankATcernch merged commit bc985a8 into AIDASoft:master Dec 5, 2024
15 checks passed
@andresailer andresailer deleted the fixAssemblyCopyNumber branch December 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Assembly volume and g4-copynumbers
2 participants