Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "CartesianGridUV" segmentation class, providing for a readout a… #1365

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

ybedfer
Copy link
Contributor

@ybedfer ybedfer commented Dec 8, 2024

…t an angle w.r.t. X,Y axes.

BEGINRELEASENOTES

  • Adding a CartesianGridUV segmentation class, providing for a stereo readout, i.e. a readout at an angle w.r.t. the axes of the sensitive volume.
  • The class is a straightforward derivation of CartesianGridXY, with only few extras needed to register the angle parameter and execute the rotation.

ENDRELEASENOTES

@ybedfer
Copy link
Contributor Author

ybedfer commented Dec 8, 2024

I can add that most of the modifications from CartesianGridXY to CartesianGridUV are obtained with the following sed patch:

sed -e "s/\([^\.]\)X/\1U/g" -e "s/\([^\.]\)Y/\1V/g" -e "s/_x/_u/g" -e "s/_y/_v/g" -e 's/"x"/"u"/g' -e 's/"y"/"v"/g' $file

where $file runs through:

DDCore/include/DD4hep/CartesianGridXY.h DDCore/include/DDSegmentation/CartesianGridXY.h DDCore/src/CartesianGridXY.cpp DDCore/src/segmentations/CartesianGridXY.cpp

…ianGridXYZ" had been cancelled inadvertently.
Copy link

github-actions bot commented Dec 9, 2024

Test Results

   14 files     14 suites   6h 4m 10s ⏱️
  368 tests   367 ✅ 0 💤 1 ❌
2 531 runs  2 530 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit f33cd02.

♻️ This comment has been updated with latest results.

@andresailer
Copy link
Member

andresailer commented Dec 9, 2024

I don't think we should call this cartesianUV, because this is not a carthesian, Orthogonal Coordinate system, any more. Rather SkewUV?

I see this really is just a rotation around Z, and the U V and Z axis are still all orthogonal.

Copy link
Member

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andresailer andresailer enabled auto-merge (rebase) December 9, 2024 16:13
@andresailer andresailer merged commit c772acc into AIDASoft:master Dec 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants