Feature celeritas integration #1370
Conversation
DDG4/include/DDG4/Celeritas.h
Outdated
| }; | ||
| } | ||
|
|
||
| // Global shared setup options |
There was a problem hiding this comment.
Does DD4HEP have a namespace? Since these are all local to DD4HEP they should probably live inside it.
There was a problem hiding this comment.
I moved the definitions under dd4hep::sim namespace
DDG4/src/Celeritas.cpp
Outdated
| // Set along-step factory | ||
| so.make_along_step = celeritas::UniformAlongStepFactory(); |
There was a problem hiding this comment.
This indicates a "zero" magnetic field: is there a way to assert that DD4HEP doesn't have a mag field definition so that it's consistent?
DDG4/src/Celeritas.cpp
Outdated
| // Use Celeritas "hit processor" to call back to Geant4 SDs. | ||
| so.sd.enabled = false; |
There was a problem hiding this comment.
We definitely shouldn't have this. Where were these lines copied from? We should probably use something closer to https://gitlab.cern.ch/bmorgan/athena/-/blob/6072d57711365aa3a58c38ff1134e3f0c569c78b/Simulation/G4Utilities/G4UserActions/src/Celeritas.cxx
There was a problem hiding this comment.
I think that's where I took it from. Am i looking in the wrong branch? https://gitlab.cern.ch/bmorgan/athena/-/blob/integrate-celeritas/Simulation/G4Utilities/G4UserActions/src/Celeritas.cxx?ref_type=heads&blame=1
Co-authored-by: Seth R. Johnson <[email protected]>
…on definitions placed outside the dd4hep::sim namespace
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 7d49231. ♻️ This comment has been updated with latest results. |
|
Hi @rahmans1 Thank you for the interesting feature. Please format the original PR message with BEGIN/ENDRELEASENOTES. |
DDG4/src/Celeritas.cpp
Outdated
| } | ||
|
|
||
| // Shared data and GPU setup | ||
| celeritas::SharedParams& CelerSharedParams() |
There was a problem hiding this comment.
| celeritas::SharedParams& CelerSharedParams() | |
| celeritas::SharedParams& dd4hep::sim::CelerSharedParams() |
if the function is declared inside the namespace in the header file?
(same for the other functions).
BEGINRELEASENOTES
Integrate track offloading to celeritas (https://celeritas-project.github.io/celeritas)
ENDRELEASENOTES