Update ROOT_LIBRARY_PATH in thisdd4hep.sh

[veprbl]

BEGINRELEASENOTES

• ROOT_LIBRARY_PATH will now be updated by thisdd4hep.sh. This is needed to instruct Cling to prefer a particular dd4hep path. see https://github.com/root-project/root/blob/a588ea2cbc286afcc5e2b06dfdcae139b470da96/README/ReleaseNotes/v624/index.md?plain=1#L76
  ENDRELEASENOTES

[github-actions]

Test Results

   16 files     16 suites   7h 5m 23s ⏱️
  370 tests   370 ✅ 0 💤 0 ❌
2 887 runs  2 887 ✅ 0 💤 0 ❌

Results for commit 2b8cbcd.

♻️ This comment has been updated with latest results.

[andresailer]

When is this needed for cling? This would not affect the creation of the rootmaps during the compilation of DD4hep.

[ybedfer]

I can add that this commit fixes my issue #1407.

[andresailer]

If we move the setting of ROOT_LIBRARY_PATH to

DD4hep/cmake/thisdd4hep.sh

Lines 43 to 53 in 42956b1

	dd4hep_add_library_path() {
	local p=${1};
	if [ @APPLE@ ]; then
	# Do not prepend system library locations on macOS. Stuff will break.
	[[ "$p" = "/usr/lib" || "$p" = "/usr/local/lib" ]] && return
	dd4hep_add_path DYLD_LIBRARY_PATH "$p"
	dd4hep_add_path DD4HEP_LIBRARY_PATH "$p"
	else
	dd4hep_add_path LD_LIBRARY_PATH "$p"
	fi
	}

also the packages depending on DD4hep benefit from this change directly

[veprbl]

When is this needed for cling? This would not affect the creation of the rootmaps during the compilation of DD4hep.

cppyy is using cling