Skip to content

Add entry_point plugin support for user defined HELM run_specs #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmjoy merged 6 commits into from
Jan 26, 2026
Merged

Add entry_point plugin support for user defined HELM run_specs #42

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50be6d5
Add entry_point plugin support for user defined HELM run_specs
dmjoy Jan 16, 2026
f81ce56
Point at kitware-helm fork; remove helm-run wrapper
dmjoy Jan 22, 2026
deac4ba
Add requirements/runtime.txt for URL kitware-helm package
dmjoy Jan 23, 2026
88398a9
Add kitware-helm URL requirement to CI tests
dmjoy Jan 23, 2026
a9ac8d3
Fixes for upstream HELM
Erotemic Jan 23, 2026
082b50f
Fix test
Erotemic Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
run: |-
python -m pip install pip uv -U
python -m uv pip install -r pyproject.toml --extra tests
python -m uv pip install -r requirements/runtime.txt
Copy link
Contributor Author

@dmjoy dmjoy Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Erotemic is this the place (and only place) I needed to add this?

Copy link
Contributor

@Erotemic Erotemic Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need it in the test_purepy_wheels section after python -m uv pip install --prerelease=allow "aiq-magnet[$INSTALL_EXTRAS]==$MOD_VERSION" -f wheelhouse. There are tow paths for testing the source dist and the wheel dist.

- name: Build sdist
shell: bash
run: |-
Expand Down
12 changes: 0 additions & 12 deletions magnet/backends/helm/magnet_run_helm.py
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ docs = [
magnet = "magnet.__main__:main"
magnet-helm-run = "magnet.backends.helm.magnet_run_helm:main"

[project.entry-points.helm]
run_specs = "magnet.backends.helm.run_specs"

[tool.pytest.ini_options]
addopts = "--xdoctest --xdoctest-style=google --ignore-glob=docs"
norecursedirs = ".git build __pycache__ dev docs dockerfiles"
Expand Down
1 change: 1 addition & 0 deletions requirements/runtime.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
crfm-helm @ git+https://github.com/AIQ-Kitware/helm@kitware-main
Loading