Add params schema support to ProcessNode and align legacy _from_scriptconfig#7
Open
Add params schema support to ProcessNode and align legacy _from_scriptconfig#7
params schema support to ProcessNode and align legacy _from_scriptconfig#7Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
paramsclass variable so path/parameter groups can be derived without factory helpers._from_scriptconfighelper while making it follow the same derivation rules as the newparamsmechanism.Description
paramsonProcessNodeand merge derived groups into instancein_paths,out_paths,algo_params,perf_params, andprimary_out_keyduring__init__only where values are missing so explicit ctor/classvars take precedence.ProcessNode._derive_groups_from_params_spec(params_spec)that accepts ascriptconfig.DataConfigclass or instance, or a plaindict, and returns(in_paths_set, out_paths_dict, algo_params_dict, perf_params_dict, primary_out_key)while implementing the following rules: no tags => algo param, raiseValueErroron conflicting bucket tags, ignore (withwarnings.warn) defaults forin_paths, use non-empty string defaults forout_paths, and include instance-provided defaults whenparamsis an instance.@classmethod _from_scriptconfigto call the shared helper and construct aProcessNodeusing the same derivation rules while keeping it marked EXPERIMENTAL and treating it as a compatibility helper.in_pathdefault triggers a warning and is ignored, explicitout_pathson the node override schema defaults, and parity betweenparams-based derivation and_from_scriptconfig.warnings, ensure safe merging whenin_paths/out_paths/algo_params/perf_paramsmay beNone, and preserve existing behavior ofself.configandconfigure().Testing
pipeline.pybut not run).Codex Task