임시용 Emotion 글로벌스타일 선언 완료 #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrySeop
added
💅🏻 style
|
✅ 끄적끄적 프리뷰 배포 완료! 🔗 프리뷰 열기
🧩 commit: |
|
✅ 끄적끄적 프리뷰 배포 완료! 🔗 프리뷰 열기
🧩 commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪄 목적
💻 상세 작업 내용
theme.ts파일을 GlobalStyle에 추가하고, 일단 파일은 냅뒀습니다. (기존 파일 형식 유지를 위함입니다.)특정 브라우저 세팅도 옮기고 불필요한 reset은 제거했습니다.
폰트크기, 기본 배경색, 글자색을 html에 선언하지않았습니다.(기존 세팅에 없었음.)
📸 스크린샷
👼🏻 리뷰 요구사항 (선택)
제가 확인해봤을때 어색한 부분이 스크롤아닌데 스크롤 생기는 것, 사이드바 이름나오는 곳 글자가 조금 커졌다? 말고는 이상이 없는 것같아서 제출했습니다 그리고 차차 속성을 추가하면 될 것 같아요! 적용해보고 이상없으면 그때
App.css,index.css,reset.ts파일을 제거하도록 하겠습니다.