Fix new bug in pure soa communication #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Feb 18, 2025
Comment on lines
246
to
250
| int num_real_comm_comp = 0; | ||
| for (int i = AMREX_SPACEDIM + NStructReal; i < real_comp_mask.size(); ++i) { | ||
| int comm_comps_start = 0; | ||
| if constexpr (!PC::ParticleType::is_soa_particle) { | ||
| comm_comps_start += AMREX_SPACEDIM + NStructReal; | ||
| } |
Src/Particle/AMReX_ParticleTile.H
Outdated
Comment on lines
137
to
140
| int array_start_index = 0; | ||
| if constexpr (!ParticleType::is_soa_particle) { | ||
| array_start_index = AMREX_SPACEDIM + NStructReal; | ||
| } |
There was a problem hiding this comment.
I upgraded to Ubuntu 24.04 and now my init.el is b0rked.
Src/Particle/AMReX_ParticleTile.H
Outdated
Comment on lines
191
to
194
| int array_start_index = 0; | ||
| if constexpr (!ParticleType::is_soa_particle) { | ||
| array_start_index = AMREX_SPACEDIM + NStructReal; | ||
| } |
Src/Particle/AMReX_ParticleTile.H
Outdated
Comment on lines
604
to
607
| int array_start_index = 0; | ||
| if constexpr (!ParticleType::is_soa_particle) { | ||
| array_start_index = AMREX_SPACEDIM + NStructReal; | ||
| } |
|
Thanks @atmyers! |
EZoni
pushed a commit
to ECP-WarpX/WarpX
that referenced
this pull request
Feb 19, 2025
Weekly update to latest AMReX. Weekly update to latest pyAMReX (no changes). Weekly update to latest PICSAR (no changes). ```console ./Tools/Release/updateAMReX.py ./Tools/Release/updatepyAMReX.py ./Tools/Release/updatePICSAR.py ``` This pulls in AMReX-Codes/amrex#4337, fixing regressions from #5669 (GPU segfaults on particle redistribute) Signed-off-by: Axel Huebl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in PR #4333.
The proposed changes: