Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client behaviour improvements #135

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Client behaviour improvements #135

merged 3 commits into from
Jul 31, 2023

Conversation

N-Nagorny
Copy link
Contributor

No description provided.


If keeping the configuration of the Sender, the Controller MUST `GET /constraints/active` from the Sender and evaluate these Active Constraints against the Constraint Sets it has built.
If keeping the configuration of the Sender, the Controller MUST `GET /constraints/active` from the Sender and provide the User with the Active Constraints and the Constraint Sets it has built or with the results of evaluation the former against the latter if the Controller is able to do such evaluation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This language will prevent a Controller to perform autonomous work as it MUST always provide to the User ... This is bad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer to keep the original text and changing the MUST for a SHOULD if the objective is to minimize the requirements of the Controller.

"If keeping the configuration of the Sender, the Controller SHOULD GET /constraints/active from the Sender and evaluate these Active Constraints against the Constraint Sets it has built. If the current Active Constraints allow streams, that would not be compliant with the Constraint Sets it has built, the Controller SHOULD inform the User that compatibility of the Sender’s stream with the chosen Receivers cannot be assured without replacing the Active Constraints."

@N-Nagorny N-Nagorny merged commit 2b6458d into v1.0-dev Jul 31, 2023
2 checks passed
@N-Nagorny N-Nagorny deleted the behaviour-client-side branch July 31, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants