Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to improve test suite conformance #37

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Updates to improve test suite conformance #37

merged 3 commits into from
Aug 1, 2023

Conversation

cristian-recoseanu
Copy link
Contributor

@cristian-recoseanu cristian-recoseanu commented Jul 28, 2023 •
edited
Loading

  • add Sequence methods wherever relevant
  • improve error response statuses
  • Remove isConstant and isPersistent flags from NcPropertyDescriptor

@cristian-recoseanu
Updates to improve test suite conformance
8b314b0 
- add Sequence methods wherever relevant
- improve error response statuses
@cristian-recoseanu
Remove isConstant and isPersistent
d5e3a85 
flags from NcPropertyDescriptor.
jonathan-r-thorpe
jonathan-r-thorpe approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@jonathan-r-thorpe jonathan-r-thorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristian-recoseanu
Update NcBlockMemberDescriptor
ea8e95d 
to correctly inherit from NcDescriptor
@cristian-recoseanu
Copy link
Contributor Author

Reviewed on the call on the 1st of August 2023.

@cristian-recoseanu cristian-recoseanu merged commit b0eed07 into main Aug 1, 2023
2 checks passed
@cristian-recoseanu cristian-recoseanu deleted the CR-test-suite-fixes branch August 1, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-r-thorpe jonathan-r-thorpe jonathan-r-thorpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristian-recoseanu @jonathan-r-thorpe