Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #38

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Various improvements #38

merged 3 commits into from
Aug 4, 2023

Conversation

cristian-recoseanu
Copy link
Contributor

@cristian-recoseanu cristian-recoseanu commented Aug 1, 2023 •
edited
Loading

  • Make NcMethodResultLength value nullable
  • Update mock to cope with handles outside the allowed range

@cristian-recoseanu cristian-recoseanu changed the title Make NcMethodResultLength value nullable Various improvements Aug 2, 2023
jonathan-r-thorpe
jonathan-r-thorpe approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jonathan-r-thorpe jonathan-r-thorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristian-recoseanu cristian-recoseanu merged commit f308805 into main Aug 4, 2023
2 checks passed
@cristian-recoseanu cristian-recoseanu deleted the CR-improvements branch August 4, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-r-thorpe jonathan-r-thorpe jonathan-r-thorpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cristian-recoseanu @jonathan-r-thorpe