BUG: Fix segfault when mask file does not exist (NOMASK)#1977
Merged
Conversation
getCachedMask unconditionally called DisconnectPipeline() after ReadImage, which sets the pointer to nullptr when the file doesn't exist. This caused a null pointer dereference segfault when using --masks '[ NOMASK,NOMASK ]' or any non-existent mask filename. The documentation states non-existent mask files should be silently ignored.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a null-check around DisconnectPipeline() to avoid dereferencing a null cached mask image when ReadImage() does not populate it.
Changes:
- Guard
cached->DisconnectPipeline()behindcached.IsNotNull()afterReadImage(). - Prevent potential null dereference in the cache-loading lambda.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I introduced this in #1970 |
cookpa
approved these changes
Jun 4, 2026
cookpa
left a comment
cookpa
left a comment
Member
There was a problem hiding this comment.
This restores the previous behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
antsRegistrationsegfaults when--masks '[ NOMASK,NOMASK ]'or any non-existent mask filename is passed.Root Cause
In
getCachedMask(Examples/antsRegistrationTemplateHeader.h:354),ReadImagesets the smart pointer tonullptrwhen the file doesn't exist. The subsequentcached->DisconnectPipeline()unconditionally dereferences this null pointer.Fix
Add a null check before calling
DisconnectPipeline(). The downstream code (AddFixedImageMask/AddMovingImageMask) already handles null masks correctly — this was the only missing guard.Verification
The command from the issue now fails gracefully instead of segfaulting: