fix: build cargo-c with --locked to work around rust-lang/cargo#13002#1785
Merged
vrabaud merged 2 commits intoAOMediaCodec:mainfrom Nov 20, 2023
Merged
fix: build cargo-c with --locked to work around rust-lang/cargo#13002#1785vrabaud merged 2 commits intoAOMediaCodec:mainfrom
vrabaud merged 2 commits intoAOMediaCodec:mainfrom
Conversation
This was referenced Nov 20, 2023
wantehchang
reviewed
Nov 20, 2023
Collaborator
wantehchang
left a comment
wantehchang
left a comment
There was a problem hiding this comment.
Thank you for the pull request. I suggest a small change.
ext/rav1e.cmd
Outdated
|
|
||
| cd rav1e | ||
| cargo install cargo-c | ||
| cargo install cargo-c --locked |
Collaborator
There was a problem hiding this comment.
Nit: List the "--locked" option before "cargo-c".
vrabaud
approved these changes
Nov 20, 2023
wantehchang
pushed a commit
to wantehchang/libavif
that referenced
this pull request
Nov 21, 2023
…AOMediaCodec#1785) (cherry picked from commit 5ba0e14)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/cargo#13002 is the cause of the build failures currently on the main branch.
There is a pull request to fix the issue in cargo (rust-lang/cargo#13004), but using
--lockedmight be advisable anyway to ensure reproducible builds.