Skip to content

add editorconfig#62

Merged
Zahnentferner merged 3 commits intoAOSSIE-Org:mainfrom
kpj2006:Editorconfig
Feb 24, 2026
Merged

add editorconfig#62
Zahnentferner merged 3 commits intoAOSSIE-Org:mainfrom
kpj2006:Editorconfig

Conversation

@kpj2006
Copy link
Contributor

@kpj2006 kpj2006 commented Feb 15, 2026

Addressed Issues:

Screenshots/Recordings:

Additional Notes:

Checklist

  • My code follows the project's code style and conventions
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contributing Guidelines

⚠️ AI Notice - Important!

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact.

Summary by CodeRabbit

  • Chores
    • Added a project-wide editor configuration to enforce consistent formatting, indentation, line endings, and whitespace rules across the codebase.
    • Includes universal defaults plus file-type specific indentation rules to reduce merge conflicts and ensure consistent edits.
    • Adds inline guidance and links to documentation to help contributors follow the conventions.

@github-actions github-actions bot added no-issue-linked PR is not linked to any issue size/M Medium PR (51-200 lines changed) labels Feb 15, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 15, 2026

Walkthrough

Adds a new .editorconfig file setting repository-wide formatting rules: root = true, UTF-8 encoding, LF line endings, trim trailing whitespace, ensure final newline, default 4-space indentation, and file-type-specific overrides (2-space for JS/TS/shell, tab for Makefiles), plus explanatory comments.

Changes

Cohort / File(s) Summary
EditorConfig Configuration
/.editorconfig
Adds .editorconfig with root = true; universal settings (utf-8, LF, trim_trailing_whitespace, insert_final_newline); default indentation 4 spaces; overrides for Markdown (no trim), JS/TS/JSON/YAML (2-space), shell scripts (2-space), Makefiles/Mk (tab, tab_width=4); includes comments and links to docs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

Make Lang

Suggested reviewers

  • Zahnentferner

Poem

🐰 A tiny file hops in place,
Spaces settle, tabs find grace,
UTF‑8 keeps every line bright,
LF and trim set formatting right,
Hop, code, hop — all files unite! 🥕

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'add editorconfig' directly and clearly describes the main change: adding an EditorConfig configuration file to the repository.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added external-contributor size/M Medium PR (51-200 lines changed) and removed size/M Medium PR (51-200 lines changed) labels Feb 15, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.editorconfig:
- Around line 22-86: The .editorconfig contains many per-file sections that
duplicate the universal [*] defaults; remove the entirely redundant sections
([*.{yml,yaml}], [*.json], [*.{js,jsx,ts,tsx}], [*.sh], [*.{toml,ini,cfg}] if
identical, [*.{xml,html,svg}], [*.{css,scss,sass,less}],
[{package.json,package-lock.json}]) and consolidate any needed overrides into
only the sections that differ from the universal [*] settings; for partially
redundant entries (e.g., [*.py], [*.java], [*.{c,cpp,h,hpp}],
[{*.gradle,*.gradle.kts}]) remove the duplicated indent_style or indent_size
lines so each section only contains settings that override the [*] defaults.

@github-actions github-actions bot added repeat-contributor PR from an external contributor who already had PRs merged pending-coderabbit-review labels Feb 22, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.editorconfig:
- Around line 29-34: Merge the two Makefile-specific sections ([Makefile] and
[*.mk]) into a single glob entry (e.g., combine into one bracketed section
covering both Makefile and .mk files) and add a tab_width setting (for example
tab_width = 4) alongside indent_style = tab so editors render tabs consistently;
update the existing [Makefile] and [*.mk] entries to a single combined section
and include the tab_width property.

---

Duplicate comments:
In @.editorconfig:
- Around line 21-23: The .editorconfig override
[*.{js,jsx,ts,tsx,json,yml,yaml}] currently sets indent_size = 2 but omits
common web markup/style file extensions, causing .html, .css, .scss, .sass,
.less, .xml, .svg to fall back to the [*] 4-space rule; update the glob in that
section (the bracketed pattern in .editorconfig) to include those extensions so
they inherit indent_size = 2 (or, if 4-space was intentional, add a clarifying
comment in .editorconfig explaining that divergence).

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.editorconfig:
- Around line 36-60: Remove the large property/glob reference block currently
embedded in .editorconfig (the explanatory block spanning the property and
file-pattern examples), keep the header link to editorconfig.org, and move the
full reference text into the repository README (or a new docs/ section) with the
same official links; update .editorconfig to be concise and focused only on
configuration declarations and a short pointer comment to the README for the
full reference.
- Around line 33-35: There are two extra blank lines breaking the
single-blank-line pattern between sections in the .editorconfig; remove one of
the blank lines so there is exactly one empty line separating configuration
sections (i.e., collapse the three consecutive blank lines down to a single
blank line) and ensure the file follows the one-blank-line convention used
elsewhere.
- Around line 21-27: The two identical override sections in .editorconfig — the
[*.{js,jsx,ts,tsx,json,yml,yaml}] block and the [*.sh] block — should be
consolidated so the single override covers both file sets; update the glob in
the JS/TS block to include the sh pattern (or otherwise merge the [*.sh] entry
into the existing override) and remove the redundant [*.sh] section so only one
indent_size = 2 override remains.

@Zahnentferner Zahnentferner merged commit 558f4dd into AOSSIE-Org:main Feb 24, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor no-issue-linked PR is not linked to any issue pending-coderabbit-review repeat-contributor PR from an external contributor who already had PRs merged size/M Medium PR (51-200 lines changed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants