"Zernike" polynomials for an elliptical aperture #97
Conversation
|
Sorry this has taken me a while to get round to. I'll have a look at it this week. |
aotools/functions/ell_zernike.py
Outdated
| #!/usr/bin/env python3 | ||
|
|
||
| import numpy as np | ||
| from zernike import RZern |
There was a problem hiding this comment.
I can't find the RZern function that you import and use here, is this something else you have added?
There was a problem hiding this comment.
I use it in the line 33 zernike = RZern(self.rmax).
However, I've thought that maybe I can use zernike from aotools to avoid the use of an extra library. I'll need some days to modify it.
There was a problem hiding this comment.
I saw that you used it, I mean't that in the zernike module there is no RZern function, so I wasn't sure if it was something you added to the zernike module but forgot to include in the pull request.
Definitley use the existing functions in aotools if you can, its just that I couldn't find this one defined in aotools.
test/test_ell_zernike.py
Outdated
There was a problem hiding this comment.
Can you rework this into simpler tests which just make sure the code doesn't crash and that the inputs and outputs are right sized arrays and types? For examples you can look at the simpler tests we have in the test_zernike.py file.
These are much more in depth tests to visualise the outputs to verify them. They are useful, but would ideally be added to the aotools_tests repository as part of the Zernike notebook.
I added the class to generate orthonormal polynomials and a wavefront map for an elliptical aperture.
I, also, added a test for it.
Best regards,
Oleksandra