Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive layout #70

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Responsive layout #70

wants to merge 9 commits into from

Conversation

edoardocavazza
Copy link
Member

@edoardocavazza edoardocavazza commented Jun 14, 2020

Issue: #62

  • Fixed some alignment issues
  • Responsive layout
  • Sticky header

Extra:

@nicolocarpignoli
Copy link
Member

@edoardocavazza it's great to me! Only one thing: it's possible to add a bigger padding on the left on each page? Something that will make the whole content not so sticky to the left margin.

For the rest, it scales great.

@nicolocarpignoli
Copy link
Member

I have aligned the branch to latest modifies.

Copy link
Collaborator

@mingiryu mingiryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edoardocavazza Definitely looks better for responsive. I don't think the back anchor component will work when it gets merged to master. If we keep what you implemented and hardcore /studio/ in front to fix for prod, then it won't work for local dev, and vice versa. I wish I knew a better way to handle it.

index.html Show resolved Hide resolved
@@ -48,7 +48,7 @@
<page-header assetsUrl="../../assets"></page-header>

<div class="pages-content">
<back-anchor assetsUrl="../../assets"></back-anchor>
<back-anchor href="/" assetsUrl="../../assets"></back-anchor>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The works for local dev, but unfortunately, it doesn't work for the prod. The reason is because the root URL on prod is https://github.com/AR-js-org/studio

style.css Outdated Show resolved Hide resolved
@gciandro13 gciandro13 self-assigned this Sep 17, 2020
@gciandro13 gciandro13 self-requested a review October 29, 2020 08:07
@gciandro13
Copy link
Member

@thauska hi :) still actual ?

@thauska
Copy link
Member

thauska commented Oct 7, 2023

I can see it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marker Page: back button
5 participants